Make PowerManagingActor more modular and generic
#773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it an internal type that only holds system bounds. It can be used for other pools also, so it will be moved to a separate module in a subsequent commit. Signed-off-by: Sahas Subramanian <[email protected]>
This allows the type to be used by the other component pools and reduces the PowerManagingActor's dependence on the battery_pool package. Signed-off-by: Sahas Subramanian <[email protected]>
And replace them with the word `component`, so that it can be used as a generic report request type for all pools. Signed-off-by: Sahas Subramanian <[email protected]>
This allows the generic `Report` class to be typed in the BatteryPool as `BatteryPoolReport` with battery-related documentation. This commit also removed mentions of batteries from the `PowerManager.Report` class docstrings. Signed-off-by: Sahas Subramanian <[email protected]>
This is in preparation for using the PowerManagingActor with different component pools. The power manager needs to get system bounds for the given set of components from the right place, and only when necessary. This requires telling the power manager which pool to get bounds from, so that it can do it dynamically. Signed-off-by: Sahas Subramanian <[email protected]>
The only ones that remain are in the interactions with the PowerDistributingActor, which will be made general purpose separately. Signed-off-by: Sahas Subramanian <[email protected]>
shsms
added
the
cmd:skip-release-notes
github-actions
bot
added
part:tests
llucax
reviewed
Nov 7, 2023
This is supposed to establish a link between the classes, making it easy to understand the code. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
llucax
previously approved these changes
Nov 8, 2023
tests/timeseries/_battery_pool/test_battery_pool_control_methods.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Sahas Subramanian <[email protected]>
The RELEASE_NOTES.md file has diverged and needs to be synced from the main branch, before it can be updated without conflicts. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
daniel-zullo-frequenz
removed
the
cmd:skip-release-notes
daniel-zullo-frequenz
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
PowerManagingActortoare supported.
PowerManagingActor, except in the interactions with thePowerDistributingActor.The
PowerDistributingActorneeds to be modularized as well, beforethe either of these actors can be used with other types of components.
All changes in this PR are internal and don't affect the external
interface of the
BatteryPool.