Skip to content

Commit 9057aee

Browse files
committed
spring-projectsGH-2252: Applied code review
1 parent e90b92c commit 9057aee

File tree

10 files changed

+17
-3
lines changed

10 files changed

+17
-3
lines changed

spring-kafka-docs/src/main/asciidoc/kafka.adoc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2471,6 +2471,10 @@ Useful when the consumer code cannot determine that an `ErrorHandlingDeserialize
24712471
|`null`
24722472
|When present and `syncCommits` is `false` a callback invoked after the commit completes.
24732473

2474+
|[[offsetAndMetadataProvider]]<<offsetAndMetadataProvider,`offsetAndMetadataProvider`>>
2475+
|`null`
2476+
|A provider for `OffsetAndMetadata`; by default, the provider creates an offset and metadata with empty metadata. The provider gives a way to customize the metadata.
2477+
24742478
|[[commitLogLevel]]<<commitLogLevel,`commitLogLevel`>>
24752479
|DEBUG
24762480
|The logging level for logs pertaining to committing offsets.

spring-kafka/src/main/java/org/springframework/kafka/listener/DefaultAfterRollbackProcessor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
* @param <V> the value type.
4545
*
4646
* @author Gary Russell
47+
* @author Francois Rosiere
4748
*
4849
* @since 1.3.5
4950
*

spring-kafka/src/main/java/org/springframework/kafka/listener/DefaultListenerMetadata.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,19 @@
1717
package org.springframework.kafka.listener;
1818

1919
import org.springframework.lang.Nullable;
20+
import org.springframework.util.Assert;
2021

2122
/**
2223
* Default implementation for {@link ListenerMetadata}.
2324
* @author Francois Rosiere
2425
* @since 2.8.6
2526
*/
26-
public class DefaultListenerMetadata implements ListenerMetadata {
27+
class DefaultListenerMetadata implements ListenerMetadata {
2728

2829
private final MessageListenerContainer container;
2930

30-
public DefaultListenerMetadata(MessageListenerContainer container) {
31+
DefaultListenerMetadata(MessageListenerContainer container) {
32+
Assert.notNull(container, "'container' must not be null");
3133
this.container = container;
3234
}
3335

spring-kafka/src/main/java/org/springframework/kafka/listener/FailedBatchProcessor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
* fallback handler.
4848
*
4949
* @author Gary Russell
50+
* @author Francois Rosiere
5051
* @since 2.8
5152
*
5253
*/

spring-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@
144144
* @author Tom van den Berge
145145
* @author Lukasz Kaminski
146146
* @author Tomaz Fernandes
147+
* @author Francois Rosiere
147148
*/
148149
public class KafkaMessageListenerContainer<K, V> // NOSONAR line count
149150
extends AbstractMessageListenerContainer<K, V> {

spring-kafka/src/main/java/org/springframework/kafka/listener/ListenerUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
* Listener utilities.
3939
*
4040
* @author Gary Russell
41+
* @author Francois Rosiere
4142
* @since 2.0
4243
*
4344
*/

spring-kafka/src/main/java/org/springframework/kafka/listener/MessageListenerContainer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
* @author Gary Russell
3737
* @author Vladimir Tsanev
3838
* @author Tomaz Fernandes
39+
* @author Francois Rosiere
3940
*/
4041
public interface MessageListenerContainer extends SmartLifecycle, DisposableBean {
4142

@@ -199,7 +200,7 @@ default String getListenerId() {
199200
* Get arbitrary static information that will be added to the
200201
* {@link KafkaHeaders#LISTENER_INFO} header of all records.
201202
* @return the info.
202-
* @since 2.8.4
203+
* @since 2.8.6
203204
*/
204205
@Nullable
205206
default byte[] getListenerInfo() {

spring-kafka/src/main/java/org/springframework/kafka/listener/SeekUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
* Seek utilities.
4545
*
4646
* @author Gary Russell
47+
* @author Francois Rosiere
4748
* @since 2.2
4849
*
4950
*/

spring-kafka/src/test/java/org/springframework/kafka/listener/DefaultAfterRollbackProcessorTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848

4949
/**
5050
* @author Gary Russell
51+
* @author Francois Rosiere
5152
* @since 2.3.1
5253
*
5354
*/

spring-kafka/src/test/java/org/springframework/kafka/listener/ListenerUtilsTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
/**
2727
* @author Gary Russell
28+
* @author Francois Rosiere
2829
* @since 2.7.1
2930
*
3031
*/

0 commit comments

Comments
 (0)