Skip to content

Offset metadata should not be lost in case of batch reprocessing #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frosiere opened this issue May 3, 2022 · 0 comments · Fixed by #2253
Closed

Offset metadata should not be lost in case of batch reprocessing #2252

frosiere opened this issue May 3, 2022 · 0 comments · Fixed by #2253
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Milestone
3.0.0-M4

Comments

@frosiere
Copy link
Contributor

frosiere commented May 3, 2022

Issue #2170 introduced a way to control the metadata associated to an offset but in case of exception during the processing of a batch, these metadata are no present anymore when records are reprocessed.

So, in this issue, we will ensure these metadata are not lost in such a case.

Javadoc of OffsetAndMetadataProvider has also been reviewed as this provider is used for both, sync and async commits.
frosiere added a commit to frosiere/spring-kafka that referenced this issue May 3, 2022
@frosiere
spring-projectsGH-2252: Keep offset metadata in case of batch reproce…
61ad2b6 
…ssing
@frosiere frosiere mentioned this issue May 3, 2022
Merged
frosiere added a commit to frosiere/spring-kafka that referenced this issue May 3, 2022
@frosiere
spring-projectsGH-2252: Keep offset metadata in case of batch reproce…
e90b92c 
…ssing
@frosiere frosiere changed the title Offsef metadata should not be lost in case of batch reprocessing Offset metadata should not be lost in case of batch reprocessing May 4, 2022
@artembilan artembilan added this to the 3.0.0-M4 milestone May 4, 2022
frosiere added a commit to frosiere/spring-kafka that referenced this issue May 4, 2022
@frosiere
spring-projectsGH-2252: Applied code review
9057aee
frosiere added a commit to frosiere/spring-kafka that referenced this issue May 5, 2022
@frosiere
spring-projectsGH-2252: Added missing static keyword
e72fed3
garyrussell pushed a commit that referenced this issue May 9, 2022
@frosiere
GH-2252: Keep offset metadata in case of batch reprocessing (#2253)
f94620a 
* GH-2252: Keep offset metadata in case of batch reprocessing

* GH-2252: Applied code review

* GH-2252: Added missing static keyword
garyrussell pushed a commit that referenced this issue May 9, 2022
@frosiere @garyrussell
GH-2252: Keep offset metadata in case of batch reprocessing (#2253)
968df68 
* GH-2252: Keep offset metadata in case of batch reprocessing

* GH-2252: Applied code review

* GH-2252: Added missing static keyword
garyrussell pushed a commit that referenced this issue May 9, 2022
@frosiere @garyrussell
GH-2252: Keep offset metadata in case of batch reprocessing (#2253)
6e92b7f 
* GH-2252: Keep offset metadata in case of batch reprocessing

* GH-2252: Applied code review

* GH-2252: Added missing static keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M4
Development

Successfully merging a pull request may close this issue.

GH-2252: Keep offset metadata in case of batch reprocessing frosiere/spring-kafka
2 participants
@artembilan @frosiere