Add a Day type to provide better handling of day value #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tguichaoua, let me know once this is ready and I'll review it. The change looks like a good improvement, happy to merge it once ready. Thank you! 🙂 |
|
@fspoettel |
fspoettel
reviewed
Nov 22, 2023
| @@ -12,7 +14,7 @@ pub fn part_two(input: &str) -> Option<u32> { | |||
| None | |||
| } | |||
|
|
|||
| advent_of_code::main!(DAY); | |||
| advent_of_code::main!(DAY_NUMBER); | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
There was a problem hiding this comment.
The unit tests still have references to DAY which should be DAY_NUMBER now.
There was a problem hiding this comment.
advent_of_code::main! creates a const value DAY of type Day.
The DAY in unit tests refer to this const.
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
Co-authored-by: Felix Spöttel <[email protected]>
fspoettel
approved these changes
Nov 22, 2023
|
Thank you for the contribution! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a type
Dayto enforce static validity of the value and provide better error message to the user.Before / after example with an invalid value
Compile time checked value
