[WIP] Execution planning phase #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolution (should be working)
|
Performance benchmark results for the latest (working but not optimized) version: Latest DEVBenchmarkDotNet=v0.9.7.0
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i5-6300HQ CPU 2.30GHz, ProcessorCount=4
Frequency=2249999 ticks, Resolution=444.4446 ns, Timer=TSC
HostCLR=MS.NET 4.0.30319.42000, Arch=32-bit RELEASE
JitModules=clrjit-v4.6.1080.0
Type=SimpleExecutionBenchmark Mode=Throughput
This PRBenchmarkDotNet=v0.9.7.0
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i5-6300HQ CPU 2.30GHz, ProcessorCount=4
Frequency=2249999 ticks, Resolution=444.4446 ns, Timer=TSC
HostCLR=MS.NET 4.0.30319.42000, Arch=32-bit RELEASE
JitModules=clrjit-v4.6.1080.0
Type=SimpleExecutionBenchmark Mode=Throughput
In general a speed remains unchanged - it's slightly faster for simple queries, and a little slower for deep complex ones. There is visible change in number of allocations performed and a little higher memory usage - which is quite obvious as we introduced an intermediate representation and an additional step between parsing and execution phases. |
Horusiath
added a commit
to Horusiath/FSharp.Data.GraphQL
that referenced
this pull request
Jul 19, 2016
Horusiath
added a commit
that referenced
this pull request
Jul 19, 2016
fix merge conflicts after #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: work in progress
/cc #53
This PR introduces a planning phase - a intermediate step, when given a query to execute and a schema, we create an intermediate representation (so called
ExecutionPlan) for that query. Execution plan solves things like:At the moment execution plan is not yet integrated into execution engine, but it has a dedicated (passing) test suite already.