Skip to content

Fix deprecation message for componentWillReceiveProps #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Fix deprecation message for componentWillReceiveProps #375

merged 1 commit into from
Feb 5, 2020

Conversation

JeremiahChurch
Copy link
Contributor

@JeremiahChurch JeremiahChurch commented Sep 18, 2019

Addresses the new warning returned by the new react version:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: GoogleMap

nothing fancy - just a straight line run of npx react-codemod rename-unsafe-lifecycles

@vincent-vaur
Copy link

Hello, when does this will be merged ?

@auser auser merged commit c54f470 into fullstackreact:master Feb 5, 2020
@auser
Copy link
Contributor

auser commented Feb 5, 2020

Hello, when does this will be merged ?

Shortly!

@rain-manek
Copy link

Any updates?

imladenov1997 added a commit to imladenov1997/google-maps-react that referenced this pull request Apr 3, 2020
…ter"

This reverts commit c54f470, reversing
changes made to 33f69e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants