Skip to content

Add JVM Target configuration option #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add JVM Target configuration option #128

wants to merge 5 commits into from

Conversation

fwcd
Copy link
Owner

@fwcd fwcd commented Jul 18, 2019

Add a configuration option kotlin.compiler.jvm.target that lets the user specify the JVM version. Currently only 1.6 and 1.8 are supported (though 9, 10, 11, 12 will be too once #109 is merged).

Additionally clean up the configuration structure by making it more hierarchial. The old structure

kotlin
+ languageServer
|   + enabled
+ debounceTime
+ snippetsEnabled

has been migrated to

kotlin
+ languageServer
|   + enabled
+ compiler
|   + jvm
|       + target
+ linting
|   + debounceTime
+ completion
    + snippets
        + enabled

Fixes #72.

fwcd added 4 commits July 18, 2019 15:28
@fwcd
Make configuration more hierarchial
d2f11aa 
Structure configuration keys into completion and linting configuration.
The old keys are still supported but deprecated.
@fwcd
Add JVM target option
4121cbe 
Let the user specify which JVM the compiler should use by providing a
configuration option. Additionally, clean up some of the configuration
updating logic by only propagating the updates if the value has been
set.
@fwcd
Let the activation indicator spin
6f90daf 
Use a spinning icon to indicate in VSCode's status bar that the language
server is launching.
@fwcd
Update default JvmTarget
7ddfd40 
Use JvmTarget.DEFAULT instead of null.
@fwcd fwcd added the enhancement New feature or request label Jul 18, 2019
@fwcd
Fix tests
504f2f0 
Update the imports in CompiledFileTest and SimpleScriptTest
@fwcd
Copy link
Owner Author

fwcd commented Jul 18, 2019

Manually rebased onto the current master.

@fwcd fwcd closed this Jul 18, 2019
@fwcd fwcd deleted the jvm-target-version branch July 18, 2019 16:39
@fwcd fwcd mentioned this pull request Jul 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please specify proper '-jvm-target' optionkotlin(INLINE_FROM_HIGHER_PLATFORM)
1 participant
@fwcd