Skip to content

Support optional chaining proposal #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lensbart opened this issue Mar 29, 2019 · 3 comments · Fixed by #267
Closed

Support optional chaining proposal #182

lensbart opened this issue Mar 29, 2019 · 3 comments · Fixed by #267

Comments

@lensbart
Copy link

lensbart commented Mar 29, 2019

Using the optional chaining proposal leads eslint-plugin-jsdoc to think that the constant being annotated is a function, while it’s not:

/** @const {boolean} test */
const test = something?.find(_ => _)

gives the following warnings:

  • Missing JSDoc @description declaration.eslint(jsdoc/require-description)
  • Missing JSDoc @param "_" declaration.eslint(jsdoc/require-param)
  • Missing JSDoc @returns declaration.eslint(jsdoc/require-returns)

while this passes without warnings:

/** @const {boolean} test */
const test = something.find(_ => _)
@golopot
Copy link
Collaborator

golopot commented May 12, 2019

This is blocked by #189 . The function getJSDocComment that causes the false positive is in eslint core.

@brettz9
Copy link
Collaborator

brettz9 commented May 17, 2019

#189 is no longer blocking as it has been merged; feel free to take up the issue if you like...

@gajus
Copy link
Owner

gajus commented May 30, 2019

🎉 This issue has been resolved in version 7.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants