Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement ESLint-deprecated getJSDocComment #189

Closed
brettz9 opened this issue Apr 7, 2019 · 1 comment · Fixed by #196
Closed

Reimplement ESLint-deprecated getJSDocComment #189

brettz9 opened this issue Apr 7, 2019 · 1 comment · Fixed by #196
Labels
enhancement released

Comments

@brettz9
Copy link
Collaborator

brettz9 commented Apr 7, 2019 •
edited
Loading

As per https://eslint.org/blog/2018/11/jsdoc-end-of-life and mentioned in #107 , we need to reimplement (or incorporate) the deprecated getJSDocComment (source).

Although they mentioned giving plenty of notice before removal, existing eslint-plugin-jsdoc code will break once it is removed, regardless of our status on reimplementing require-jsdoc (#162) or valid-jsdoc (#107).
@brettz9 brettz9 mentioned this issue Apr 7, 2019
Closed
6 tasks
This was referenced Apr 8, 2019
Merged
Open
@golopot golopot mentioned this issue May 12, 2019
Closed
@gajus
Copy link
Owner

gajus commented May 21, 2019

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate ESLint-deprecated getJSDocComment brettz9/eslint-plugin-jsdoc
2 participants
@brettz9 @gajus