Skip to content

chore(doc):Add babel preset css prop to jest-preprocess.js #22181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

KonnorRogers
Copy link
Contributor

Description

Add @emotion/babel-preset-css-prop to the jest-preprocess.js file. This allows for the stringificaiton of CSS properties in snapshot testing. Currently, with Emotion 10, if the babel option is not set, you will not have readable css properties. @emotion/babel-preset-css-prop is shipped by default with Emotion 10 and does not need to be installed seperately by npm.

Documentation

https://github.com/emotion-js/emotion/tree/master/packages/babel-preset-css-prop

@KonnorRogers KonnorRogers requested a review from a team as a code owner March 11, 2020 15:15
@laurieontech laurieontech added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Mar 11, 2020
@Ekwuno Ekwuno changed the title Add babel preset css prop to jest-preprocess.js chore(doc):Add babel preset css prop to jest-preprocess.js Mar 23, 2020
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. According to the official documentation, it checks out.

@Ekwuno Ekwuno merged commit 5a0d5dc into gatsbyjs:master Mar 24, 2020
@gatsbot
Copy link

gatsbot bot commented Mar 24, 2020

Holy buckets, @ParamagicDev — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants