Skip to content

restructure project to keep components and their styles/markup together #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graingert opened this issue Nov 28, 2016 · 2 comments
Closed

Comments

@graingert
Copy link

graingert commented Nov 28, 2016

eg:

css/lib/bootstrap3.min.css
html/index.html
js/config/Categories.js

Your source code directories should be chosen by feature, not filetype. This keeps style, markup and code together when navigating your codebase.

There's no need to add extra redundant file type information to your paths, we already know it's a js file because the path ends with js. You can use **/*.js to select them in scripts.

@graingert
Copy link
Author

If you want to set different caching strategies per filetype, you can use webpack to move different asset types into different directories automatically.

@graingert graingert changed the title duplicate filetype information in paths restructure project to keep components and their styles/markup together Nov 28, 2016
@n1474335
Copy link
Member

Hi @graingert,

You make some good points. We'll keep the structure as it is for now but will revisit this when our library management plans come to fruition (#2).

mattnotmitt pushed a commit to mattnotmitt/CyberChef that referenced this issue Feb 17, 2018
j433866 added a commit that referenced this issue May 21, 2019
Bring up to date with gchq/master
n1474335 pushed a commit that referenced this issue Apr 14, 2022
BRAVO68WEB referenced this issue in BRAVO68WEB/CyberChef May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants