Have "From Hex" treat the delimiter as delimiter, not what to erase #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good spot. This was definitely a bug. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1211
fix #1285
Have "From Hex" treat the delimiter as delimiter, not what to erase.
This will change the output of "From Hex" for an input
0x12 0x34 0x5 0x6with delimiter "Auto" from12 34 56to12 34 05 06(after applying "To Hex").I think the latter output is more natural.
Note that this change breaks some test cases that uses non-hexadecimal strings like
"some key"with"Hex"option.Such input didn't make sense for me, so I changed thiese cases to use
"utf8"option instead.Please let me know if you don't agree.