Skip to content

Fix Generate TOTP & HOPT #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 15, 2025
Merged

Fix Generate TOTP & HOPT #1966

merged 9 commits into from
Feb 15, 2025

Conversation

exactlyaron
Copy link
Contributor

@exactlyaron exactlyaron commented Jan 23, 2025 •
edited
Loading

Fixes #1964

Updated Generate TOTP & Generate HOTP to use OPTAuth package.

Updated HOTP test.

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@exactlyaron exactlyaron changed the title Fix Generate TOTP Fix Generate TOTP & HOPT Jan 23, 2025
@a3957273 a3957273 merged commit 95c6406 into gchq:master Feb 15, 2025
4 checks passed
@a3957273
Copy link
Member

Thanks so much for fixing these, the library you changed to also seems to have much more widespread use and support. :)

@exactlyaron exactlyaron deleted the fix/generate-totp-issue-1964 branch February 27, 2025 09:55
@exactlyaron exactlyaron mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report: Generate TOTP incorrect calculations
3 participants
@exactlyaron @CLAassistant @a3957273