Skip to content

Geoips not working (api change) #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Thinkscape opened this issue Oct 6, 2013 · 14 comments · Fixed by #273
Closed

Geoips not working (api change) #267

Thinkscape opened this issue Oct 6, 2013 · 14 comments · Fixed by #273

Comments

@Thinkscape
Copy link
Member

It seems that geoips format has changed... the provider is not working anymore.

Here's an example structure of a result:

image

@Thinkscape
Copy link
Member Author

Yeah... it changed: http://www.geoips.com/en/developer/api-guide

@willdurand
Copy link
Member

Ah.. Bad luck.. Could you come up with a patch?

@Thinkscape
Copy link
Member Author

I'll take care of that mate :-)

@willdurand
Copy link
Member

Thank you!

@willdurand
Copy link
Member

poke @Thinkscape

@Thinkscape
Copy link
Member Author

ugh.

Still here :-) sorry, got distracted.

@willdurand
Copy link
Member

poke (again) @Thinkscape

@Thinkscape
Copy link
Member Author

Interesting ... I can't seem to install deps because:

Loading composer repositories with package information
Installing dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for ext-geoip 1.0.8 -> satisfiable by ext-geoip[1.0.8].
    - geoip/geoip v1.13 conflicts with ext-geoip[1.0.8].
    - Installation request for geoip/geoip ~1.13 -> satisfiable by geoip/geoip[v1.13].

Did I miss something ? Why does geoip/geoip conflict with the extension ?

@willdurand
Copy link
Member

doh! I have no clue yet..

@Thinkscape
Copy link
Member Author

$ php --ri geoip

geoip

geoip support => enabled
geoip extension version => 1.0.8
geoip library version => 1004005

Directive => Local Value => Master Value
geoip.custom_directory => no value => no value

@Thinkscape
Copy link
Member Author

Meh...

PHP Fatal error:  Cannot redeclare geoip_country_code_by_name() in /Projects/Geocoder/vendor/geoip/geoip/geoip.inc on line 439

Fatal error: Cannot redeclare geoip_country_code_by_name() in /Projects/Geocoder/vendor/geoip/geoip/geoip.inc on line 439

That's why it conflicts. Apparently it declares the same set of functions. I believe a fixup of composer.json is in place (so it used either of those, instead of trying to install both)

@willdurand
Copy link
Member

Ah yes... There is a lib that mimics the API of the geoip ext

@Thinkscape
Copy link
Member Author

Wait... the format changes depending on query ... ugh. Hold on. I'll get to the bottom of this.

Thinkscape added a commit to Thinkscape/Geocoder that referenced this issue Nov 5, 2013
@Thinkscape
Copy link
Member Author

There ya go!

Thinkscape added a commit to Thinkscape/Geocoder that referenced this issue Nov 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants