Skip to content

Updating GeoIPs provider to expect a single location response #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2014

Conversation

kaiwa
Copy link
Contributor

@kaiwa kaiwa commented Jan 2, 2014

One change to expect multiple locations returned by the service as proposed in PR #273 and merged at 622ac5e seems not to be valid anymore.

The API Documentation describes a single location xml element in accordance with the response i get from querying the service.

FYI ping @Thinkscape

@kaiwa
Copy link
Contributor Author

kaiwa commented Jan 2, 2014

Hm the unit tests need some work too

@Thinkscape
Copy link
Member

Does this mean they changed their API again ?

@kaiwa
Copy link
Contributor Author

kaiwa commented Jan 2, 2014

I wasn't using their service before, but yes, looks like they have changed it

@willdurand
Copy link
Member

Looks like they don't support multiple responses anymore...

@kaiwa
Copy link
Contributor Author

kaiwa commented Jan 3, 2014

✅ Updated the unit tests, ready

@willdurand
Copy link
Member

Great! I will get in touch with the geoips guys to understand why they made this change, or why we thought it was possible to retrieve more than one result.

@willdurand
Copy link
Member

FYI

Hi William,

Recently, we modified our API, and now we offer only one location per call. We tried not to change to many
elements from API response, but indeed we don't offer anymore the multiple location feature. Also, we integrated
some other information in our API: languages and currencies. Please go to our GeoIPs API Guide
(http://www.geoips.com/en/developer/api-guide) in order to obtain more information about the new API. The old API
was available until the end of December.
If you need some more information, please inform us.
Thank you for you interest with GeoIPs API.

best regards,
GeoiPs Team

willdurand added a commit that referenced this pull request Jan 5, 2014
Updating GeoIPs provider to expect a single location response
@willdurand willdurand merged commit b3e9649 into geocoder-php:master Jan 5, 2014
@willdurand
Copy link
Member

Thanks!

@willdurand
Copy link
Member

2.4.2 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants