Added support in MapQuestProvider for licensed endpoints #318 #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function __construct(HttpAdapterInterface $adapter, $apiKey, $locale = null) | ||
| public function __construct(HttpAdapterInterface $adapter, $apiKey, $licensed = false, $locale = null) |
There was a problem hiding this comment.
I think $licensed = false should be the last parameter in the constructor :)
|
👍 Can you update the doc too ? |
|
I think it's safe to merge this :) |
|
@jpb0104 could you please squash your commits? @toin0u really? it looks good to me, but tests are failing.. |
|
@willdurand Tests are failling because of this https://github.com/geocoder-php/Geocoder/blob/master/tests/Geocoder/Tests/Provider/GoogleMapsProviderTest.php#L262 (1 instead of 12) We need to fix it but I think we can merge (after squashing) this because it's not related to this PR :) |
|
Squashed. |
willdurand
added a commit
that referenced
this pull request
Jul 4, 2014
Added support in MapQuestProvider for licensed endpoints #318
|
\o/ Thank you @jpb0104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional constructor parameter to access the MapQuest licensed endpoints.
Discussion in #318.