Skip to content

TST: Fix CI for pandas 1.1.0 #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2020
Merged

Conversation

martinfleis
Copy link
Member

Closes #1543
Closes #1541

Fixed condition to check for pandas 1.1.0 version and added ValueError as an option for idxmax.

@martinfleis martinfleis requested a review from brendan-ward July 28, 2020 19:42
@brendan-ward brendan-ward merged commit 55ca917 into geopandas:master Jul 31, 2020
@brendan-ward
Copy link
Member

Thanks @martinfleis !

@martinfleis martinfleis deleted the fix_-1543 branch July 31, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: test_groupby fails on pandas 1.1.0 BUG: test_numerical_operations fails under pandas 1.1.0
2 participants