feat: Emit metadata.recorder.type #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symwell
approved these changes
Sep 19, 2022
Comment on lines
-8
to
10
| APPMAP_FORMAT_VERSION = '1.7.0' | ||
| APPMAP_FORMAT_VERSION = '1.9.0' | ||
|
|
||
| SUPPORTED_RUBY_VERSIONS = %w[2.5 2.6 2.7 3.0 3.1].freeze |
There was a problem hiding this comment.
Wondering if AppMap is deprecating support for Ruby 2.5 after seeing this change in a different pr. Doesn't need to happen in this pr.
|
Good point. What's going on here is that 2.5 is generally known to work,
but we won't support it with are version-specific specific bug fixes, since
it's deprecated by the Ruby dev team
…On Mon, Sep 19, 2022 at 2:03 PM symwell ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In lib/appmap/version.rb
<#284 (comment)>
:
> - APPMAP_FORMAT_VERSION = '1.7.0'
+ APPMAP_FORMAT_VERSION = '1.9.0'
SUPPORTED_RUBY_VERSIONS = %w[2.5 2.6 2.7 3.0 3.1].freeze
Wondering if AppMap is deprecating support for Ruby 2.5 after seeing this
<https://github.com/applandinc/appmap-ruby/pull/282/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485L8>
change in a different pr. Doesn't need to happen in this pr.
—
Reply to this email directly, view it on GitHub
<#284 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVC63L3VSB2XTH766UHOTV7CTHVANCNFSM6AAAAAAQQKLTFI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Supports AppMap version 1.9.0
kgilpin
force-pushed
the
feat/recorder-type
branch
from
a2ff938 to
6358669
Compare
|
🎉 This PR is included in version 0.91.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports AppMap version 1.9.0
getappmap/appmap#32