poc(sentry): send events from a separate thread #16
Conversation
| return () => { | ||
| return { | ||
| send: (envelope) => { | ||
| worker.postMessage(envelope); |
There was a problem hiding this comment.
My only concern here is that there might be some back-pressure issues here in high volume scenarios, but that should be no problem with the volume we have with jest
| let transport = makeNodeTransport({}); | ||
|
|
||
| parentPort.on("message", (message) => { | ||
| transport.send(envelope); |
There was a problem hiding this comment.
Do we have to make envelope -> message here?
|
@AbhiPrasad I actually have a blocking problem here - the SDK's makeNodeTransport factory functions expects an object with |
| return () => { | ||
| return { |
There was a problem hiding this comment.
Can we move constructing the worker here, then we can pass down the URL as a argv to the Worker constructor. That should make it easy to pass down the url right? (since the function returning should get url as an option).
This is a poc of sending events to sentry via worker thread. The hypothesis is that currently, jest cannot move to the next test file while a promise is pending, offloading that to a separate thread would allow it to keep executing test files and enqueuing network requests on a separate thread.
Before continuing with the idea, I would like to investigate in optimizing some transport params first.