[WIP] fix: Remove debug information from release builds #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyo
changed the title
|
@mitsuhiko I guess we don't really need that |
|
Without that, stack traces are not quite as usable. I am wondering though why build times are that high to begin with. |
tonyo
changed the title
|
Is there a chance that we hit one of these? |
|
I really want to keep debug info for release builds. I don't think we hit either of the cases linked. |
|
I can locally reproduce the build failure for i686 with current (1.26.2) and nightly Rust. I suggest to disable those 32-bit builds (for both Linux and Windows) temporarily, so we're not fully blocked by this. |
tonyo
changed the title
|
Closing this. We want to keep debug info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.