Skip to content

Do not leak extensions of external classes #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marandaneto opened this issue May 22, 2023 · 2 comments
Closed

Do not leak extensions of external classes #1471

marandaneto opened this issue May 22, 2023 · 2 comments
Assignees
@denrase
Labels
Breaking-change Platform: Dart repository maintenance
Milestone
8.0.0

Comments

@marandaneto
Copy link
Contributor

Description

Key.toStringValue and Iterable.firstWhereOrNull are leaking to the final App.

Ideally, the SDK does not leak any of our external extensions, last case, we can create Util functions.
@marandaneto marandaneto added this to the 8.0.0 milestone May 22, 2023
@github-project-automation github-project-automation bot moved this to Needs Discussion in [DEPRECATED] Mobile SDKs May 22, 2023
@marandaneto marandaneto mentioned this issue May 22, 2023
Merged
6 tasks
@marandaneto
Copy link
Contributor Author

It could also clash with people's extensions.

@marandaneto marandaneto moved this from Needs Discussion to Backlog in [DEPRECATED] Mobile SDKs May 25, 2023
@marandaneto
Copy link
Contributor Author

marandaneto commented Jul 24, 2023 •
edited
Loading

Check all the extensions and move to a reusable function in case they are leaking to Apps and polluting public APIs.
Base on the v8 branch.

@denrase denrase moved this from Backlog to In Progress in [DEPRECATED] Mobile SDKs Jul 31, 2023
@denrase denrase mentioned this issue Aug 1, 2023
Merged
6 tasks
@denrase denrase moved this from In Progress to Done in [DEPRECATED] Mobile SDKs Sep 4, 2023
@denrase denrase closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denrase denrase

Labels
Breaking-change Platform: Dart repository maintenance
Projects
[DEPRECATED] Mobile SDKs
Archived in project
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@kahest @denrase @marandaneto