-
-
Notifications
You must be signed in to change notification settings - Fork 255
Improve SentryException#value
, remove stringified stack trace
#1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SentryException#value
, remove stringified stack trace
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 181 181
Lines 5776 5779 +3
=======================================
+ Hits 5209 5212 +3
Misses 567 567
☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8cb6557 | 321.20 ms | 370.46 ms | 49.26 ms |
e893df5 | 310.60 ms | 380.58 ms | 69.98 ms |
af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
a1a1545 | 295.21 ms | 351.16 ms | 55.95 ms |
ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
8a7f528 | 290.27 ms | 341.80 ms | 51.53 ms |
559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
6d7a391 | 331.94 ms | 367.04 ms | 35.10 ms |
2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
fcd1ee4 | 298.96 ms | 376.04 ms | 77.09 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8cb6557 | 6.06 MiB | 7.03 MiB | 997.01 KiB |
e893df5 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
a1a1545 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
8a7f528 | 6.06 MiB | 7.03 MiB | 989.36 KiB |
559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
6d7a391 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
fcd1ee4 | 6.16 MiB | 7.13 MiB | 1000.85 KiB |
Previous results on branch: feat/improve-sentry-exception-value
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae20cfb | 294.58 ms | 345.96 ms | 51.38 ms |
4d1ac36 | 362.30 ms | 410.94 ms | 48.64 ms |
e9bf9bd | 338.76 ms | 377.23 ms | 38.48 ms |
b2e6faa | 331.94 ms | 375.81 ms | 43.87 ms |
f3bc9f4 | 348.11 ms | 401.10 ms | 52.99 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae20cfb | 6.16 MiB | 7.13 MiB | 1000.82 KiB |
4d1ac36 | 6.15 MiB | 7.13 MiB | 1002.40 KiB |
e9bf9bd | 6.15 MiB | 7.13 MiB | 999.91 KiB |
b2e6faa | 6.15 MiB | 7.13 MiB | 1000.01 KiB |
f3bc9f4 | 6.15 MiB | 7.13 MiB | 1000.33 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
69670c9 | 1269.18 ms | 1288.69 ms | 19.51 ms |
f96ca24 | 1264.39 ms | 1287.98 ms | 23.59 ms |
3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
dd1f7d2 | 1263.16 ms | 1275.15 ms | 11.99 ms |
8cb6557 | 1265.14 ms | 1266.08 ms | 0.94 ms |
5aab4c5 | 1247.08 ms | 1271.17 ms | 24.09 ms |
457a85b | 1275.17 ms | 1285.51 ms | 10.34 ms |
b49bf00 | 1248.00 ms | 1260.35 ms | 12.35 ms |
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
e2d89fc | 1251.80 ms | 1261.92 ms | 10.11 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
69670c9 | 8.10 MiB | 9.08 MiB | 1004.49 KiB |
f96ca24 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
dd1f7d2 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
8cb6557 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
5aab4c5 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
457a85b | 8.09 MiB | 9.07 MiB | 1000.88 KiB |
b49bf00 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
e2d89fc | 8.10 MiB | 9.16 MiB | 1.06 MiB |
Previous results on branch: feat/improve-sentry-exception-value
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae20cfb | 1264.68 ms | 1271.02 ms | 6.34 ms |
e9bf9bd | 1238.84 ms | 1245.80 ms | 6.96 ms |
f3bc9f4 | 1234.08 ms | 1237.06 ms | 2.98 ms |
b2e6faa | 1277.55 ms | 1285.22 ms | 7.67 ms |
4d1ac36 | 1249.86 ms | 1262.48 ms | 12.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae20cfb | 8.29 MiB | 9.36 MiB | 1.07 MiB |
e9bf9bd | 8.29 MiB | 9.36 MiB | 1.07 MiB |
f3bc9f4 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
b2e6faa | 8.29 MiB | 9.36 MiB | 1.07 MiB |
4d1ac36 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denrase let's make CI happy and address the open comment, after that, LGTM.
📜 Description
SentryException.value
.💡 Motivation and Context
Closes #1421
💚 How did you test it?
Tests
📝 Checklist
sendDefaultPii
is enabled