Skip to content

Add support to null safety #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 7 tasks
bruno-garcia opened this issue Dec 16, 2020 · 24 comments
Closed
5 of 7 tasks

Add support to null safety #247

bruno-garcia opened this issue Dec 16, 2020 · 24 comments
Milestone

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Dec 16, 2020

Flutter is gearing up towards null-safety.

This issue is to track progress adding support to it.

Related to #99

The migration steps are here: https://dart.dev/null-safety/migration-guide

Important to note we should start by migrating our dependencies to the null safety version.

@marandaneto
Copy link
Contributor

package_info not null-safety ready, but easy to get rid of.
uuid not null-safety ready, not hard to get rid of but it'd be a breaking change.
http not null-safety ready, hard to get rid of and it'd be a breaking change.

@marandaneto
Copy link
Contributor

@bruno-garcia for me, this is a dup.
what's the motivation for creating a new one? see #99

I'd suggest either closing this one or the other.

@bruno-garcia bruno-garcia added this to the 5.0.0 milestone Jan 4, 2021
@ueman
Copy link
Collaborator

ueman commented Jan 29, 2021

http, uuid and device_info are now migrated to nullsafety.

@marandaneto
Copy link
Contributor

we need package_info though.
https://pub.dev/packages/package_info/versions
that's the easiest one to get rid of anyway.

@ueman
Copy link
Collaborator

ueman commented Feb 7, 2021

package_info has also joined the null safety club. So the migration is now unblocked.

@marandaneto
Copy link
Contributor

https://pub.dev/packages/http/versions/0.13.0 even went null-safety GA already, so we'll lose 10 pub points https://pub.dev/packages/sentry/score

@ueman
Copy link
Collaborator

ueman commented Feb 24, 2021

#250 and #311 are missing for a null safe release.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 4, 2021

Today null safety becomes stable! Is there any updates?

@ueman
Copy link
Collaborator

ueman commented Mar 4, 2021

Sentry Dart needs to be rebased on the latest main branch. Sentry Flutter is yet to be migrated.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 5, 2021

@ueman Thanks for the reply! Is there anything I can help?

@j574144
Copy link

j574144 commented Mar 5, 2021

Maybe this is reggard to safety null support:

I try update sentry 4.0.6 version with http 0.13.0 version

Because sentry >=4.0.0-alpha.1 depends on http ^0.12.0 and <appName> depends on http ^0.13.0, sentry >=4.0.0-alpha.1 is forbidden.

@marandaneto
Copy link
Contributor

@j574144 it is

@marandaneto
Copy link
Contributor

marandaneto commented Mar 5, 2021

@fzyzcjy thanks for that, if you have some spare time and would like to contribute, I've updated the description with the missing bits to finish this, here a resume:

Migrate the sentry_flutter package, https://github.com/getsentry/sentry-dart/tree/main/flutter;
CI uses new Action #334; (Dart and Flutter CI)
Rename conflicting classes #250;

Let us know if you'd like to start one of them, so we will be sure that we'll get this moving and that 2 people don't work in the same thing, I'm happy to assist with code review.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 5, 2021

@marandaneto I will look at the first one firstly (not currently, but possibly today or tomorrow, I will let you know when I start doing it).

Shall I look at the https://github.com/getsentry/sentry-dart/tree/feat/null-safety branch? It seems that the main branch has no updates

By the way, when will the null-safe sentry package be published?

@marandaneto
Copy link
Contributor

@fzyzcjy yeah start it from the branch.
both packages would be published together I'd say, so we assure compatibility.

@twogood
Copy link

twogood commented Mar 5, 2021

uuid 3 with null safety is released now :)

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 5, 2021

@marandaneto I start working on it recently, and will push a PR soon.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 5, 2021

@marandaneto PR created #337

@marandaneto
Copy link
Contributor

I'm gonna cut a prerelease on Monday :)

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Mar 7, 2021

@marandaneto Looking forward to it!

@marandaneto
Copy link
Contributor

https://github.com/getsentry/sentry-dart/releases/tag/4.1.0-nullsafety.0

thanks once more @ueman and @fzyzcjy

feedback is welcomed :)

I'll close this issue as the other 2 items have its own issue.

@pushpendraKh
Copy link

@marandaneto When can we expect the stable release for null safety?

@marandaneto
Copy link
Contributor

@pushpendraKh releasing a new pre-release today and waiting for a bit more feedback, we don't want to break the user's code.

@marandaneto marandaneto unpinned this issue Mar 31, 2021
@marandaneto
Copy link
Contributor

https://github.com/getsentry/sentry-dart/releases/tag/5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants