Skip to content

NNBD Migration #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxlapides opened this issue Feb 12, 2021 · 1 comment
Closed

NNBD Migration #296

maxlapides opened this issue Feb 12, 2021 · 1 comment

Comments

@maxlapides
Copy link

It's particularly important for this Sentry package to upgrade to Dart NNBD (non-null by default) because this package is incompatible with the null-safe version of the http library. The http library has a breaking change in 0.13.0. So, force-upgrading http to 0.13.0 will result in this error:

../../.pub-cache/hosted/pub.dartlang.org/sentry-4.0.4/lib/src/noop_client.dart:25:20: Error: The method 'NoOpClient.delete' has fewer named arguments than those of overridden method 'Client.delete'.
Future<Response> delete(url, {Map<String, String> headers}) => _response;

Because of this incompatibility, it is not currently possible to upgrade the http package to the null-safe version, which is in turn blocking us from upgrading other packages as well. Thank you!

@maxlapides
Copy link
Author

Sorry, duplicate of #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant