-
-
Notifications
You must be signed in to change notification settings - Fork 255
enha: Flutter min version test #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 91.39% // Head: 91.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 9 9
Lines 186 186
=======================================
Hits 170 170
Misses 16 16 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
25e9b59 | 307.00 ms | 348.83 ms | 41.83 ms |
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
04db237 | 330.16 ms | 428.38 ms | 98.22 ms |
a49594a | 282.27 ms | 344.84 ms | 62.57 ms |
9c5aec6 | 287.33 ms | 320.94 ms | 33.61 ms |
453e1bc | 320.41 ms | 372.73 ms | 52.32 ms |
af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
25e9b59 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
04db237 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
a49594a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
9c5aec6 | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
453e1bc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
Previous results on branch: enha/flutter-min-version-test
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
180ec29 | 310.92 ms | 358.80 ms | 47.88 ms |
0177b6b | 300.81 ms | 349.96 ms | 49.15 ms |
4900eba | 305.50 ms | 348.72 ms | 43.22 ms |
f44f042 | 292.18 ms | 316.96 ms | 24.78 ms |
37f7bf2 | 302.85 ms | 353.33 ms | 50.47 ms |
d7d9aa9 | 339.22 ms | 372.62 ms | 33.40 ms |
5158fc5 | 300.43 ms | 356.90 ms | 56.47 ms |
c49118c | 397.14 ms | 473.69 ms | 76.55 ms |
0868ea1 | 334.63 ms | 399.16 ms | 64.53 ms |
d81fddf | 311.82 ms | 375.16 ms | 63.34 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
180ec29 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
0177b6b | 5.94 MiB | 6.95 MiB | 1.01 MiB |
4900eba | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
f44f042 | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
37f7bf2 | 5.94 MiB | 6.92 MiB | 1005.76 KiB |
d7d9aa9 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
5158fc5 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
c49118c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
0868ea1 | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
d81fddf | 5.94 MiB | 6.95 MiB | 1.01 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
abcdba3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
3e5ee37 | 1248.25 ms | 1265.38 ms | 17.13 ms |
6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
6d317ea | 1277.27 ms | 1287.47 ms | 10.20 ms |
4efee31 | 1270.33 ms | 1285.75 ms | 15.42 ms |
3e9fb0e | 1262.49 ms | 1280.65 ms | 18.16 ms |
9c5aec6 | 1266.51 ms | 1274.65 ms | 8.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
abcdba3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
3e5ee37 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
6d317ea | 8.15 MiB | 9.12 MiB | 986.26 KiB |
4efee31 | 8.15 MiB | 9.12 MiB | 991.35 KiB |
3e9fb0e | 8.15 MiB | 9.12 MiB | 989.77 KiB |
9c5aec6 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
Previous results on branch: enha/flutter-min-version-test
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81fddf | 1258.06 ms | 1293.60 ms | 35.54 ms |
5158fc5 | 1288.92 ms | 1292.88 ms | 3.96 ms |
3e4f9b7 | 1286.00 ms | 1307.24 ms | 21.24 ms |
480c85a | 1271.06 ms | 1294.06 ms | 23.00 ms |
657d27d | 1286.43 ms | 1304.55 ms | 18.12 ms |
360290d | 1299.71 ms | 1317.83 ms | 18.12 ms |
5f85c3a | 1267.65 ms | 1282.14 ms | 14.49 ms |
559a2c3 | 1278.64 ms | 1295.18 ms | 16.55 ms |
c028b3e | 1292.98 ms | 1318.98 ms | 26.00 ms |
893961e | 1289.79 ms | 1318.25 ms | 28.46 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81fddf | 8.16 MiB | 9.15 MiB | 1021.77 KiB |
5158fc5 | 8.16 MiB | 9.15 MiB | 1021.88 KiB |
3e4f9b7 | 8.15 MiB | 9.13 MiB | 1000.12 KiB |
480c85a | 8.15 MiB | 9.12 MiB | 986.26 KiB |
657d27d | 8.15 MiB | 9.12 MiB | 986.24 KiB |
360290d | 8.15 MiB | 9.12 MiB | 986.29 KiB |
5f85c3a | 8.15 MiB | 9.12 MiB | 986.27 KiB |
559a2c3 | 8.15 MiB | 9.12 MiB | 986.25 KiB |
c028b3e | 8.15 MiB | 9.13 MiB | 1000.38 KiB |
893961e | 8.15 MiB | 9.13 MiB | 1000.42 KiB |
@denrase whats missing for this PR to land? can I help with something? |
@marandaneto Need to check why we are failing, jest merged in the current main branch. |
# Conflicts: # flutter/example/lib/main.dart
#skip-changelog
📜 Description
Closes #924 (comment)
Add a unit test that starts the flutter example app on iOS and Android and calls the Sentry SDK setup. Use Google tested versions as minimum, and treat the ones below as best effort.
💡 Motivation and Context
1415.2💚 How did you test it?
Add integration test.
📝 Checklist
🔮 Next steps
min_version_test
?