Skip to content

Bump coverage to node 16 #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Bump coverage to node 16 #1076

merged 4 commits into from
Oct 13, 2022

Conversation

marandaneto
Copy link
Contributor

📜 Description

Bump coverage CI action that uses node 16
#skip-changelog

💡 Motivation and Context

Closes #1069

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto enabled auto-merge (squash) October 12, 2022 11:24
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 89.98% // Head: 91.37% // Increases project coverage by +1.38% 🎉

Coverage data is based on head (d046b9c) compared to base (02419b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   89.98%   91.37%   +1.38%     
==========================================
  Files         115        9     -106     
  Lines        3585      197    -3388     
==========================================
- Hits         3226      180    -3046     
+ Misses        359       17     -342     
Impacted Files Coverage Δ
.../lib/src/enricher/io_enricher_event_processor.dart
dart/lib/src/sentry_envelope.dart
dart/lib/src/sentry_tracer_finish_status.dart
dart/lib/src/transport/rate_limit.dart
dart/lib/src/protocol/sentry_stack_frame.dart
dart/lib/src/protocol/sentry_exception.dart
dart/lib/src/sentry_user_feedback.dart
dart/lib/src/utils/isolate_utils.dart
dart/lib/src/sentry_envelope_item.dart
dart/lib/src/client_reports/discard_reason.dart
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 321.74 ms 362.20 ms 40.46 ms
Size 5.94 MiB 6.92 MiB 1004.83 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
633cf2e 289.36 ms 340.38 ms 51.02 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
4efee31 308.92 ms 368.68 ms 59.76 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
af2d175 279.08 ms 312.37 ms 33.29 ms
21845e2 345.08 ms 382.82 ms 37.74 ms

App size

Revision Plain With Sentry Diff
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB

@marandaneto marandaneto merged commit e187bee into main Oct 13, 2022
@marandaneto marandaneto deleted the bump/node16 branch October 13, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 12 actions are deprecated
3 participants