-
-
Notifications
You must be signed in to change notification settings - Fork 255
Add SentryRequest context for HttpException and SocketException #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 90.09% // Head: 89.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
- Coverage 90.09% 89.95% -0.14%
==========================================
Files 117 110 -7
Lines 3605 3456 -149
==========================================
- Hits 3248 3109 -139
+ Misses 357 347 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dart/lib/src/event_processor/exception/io_exception_event_processor.dart
Outdated
Show resolved
Hide resolved
dart/lib/src/event_processor/exception/io_exception_event_processor.dart
Show resolved
Hide resolved
dart/lib/src/event_processor/exception/io_exception_event_processor.dart
Show resolved
Hide resolved
dart/lib/src/event_processor/exception/io_exception_event_processor.dart
Outdated
Show resolved
Hide resolved
dart/lib/src/event_processor/exception/io_exception_event_processor.dart
Outdated
Show resolved
Hide resolved
dart/lib/src/event_processor/exception/io_exception_event_processor.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ueman
The failures come again because of the newly introduced |
yeah, it's pana, after publishing it, it will be green. |
📜 Description
Add SentryRequest context for HttpException and SocketException.
Also SocketException and FileSystemException have an underlying OSError, which is now reported as underlying exception.
I've also done some small refactoring of moving the enricher event processors into the event processor folder. I've also added a new constructor to
SentryRequest
and removed duplicated code.💡 Motivation and Context
HttpExceptions and SocketException can now be filtered via the request context.
💚 How did you test it?
Added new tests.
📝 Checklist
🔮 Next steps