Skip to content

Chore: consider using let instead of var type #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Chore: consider using let instead of var type #1130

merged 1 commit into from
Nov 14, 2022

Conversation

sgsm74
Copy link
Contributor

@sgsm74 sgsm74 commented Nov 13, 2022

because variable 'sdkPackages' was never mutated

📜 Description

💡 Motivation and Context

💚 How did you test it?

#skip-changelog

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

because variable 'sdkPackages' was never mutated
@marandaneto
Copy link
Contributor

Makes sense @sgsm74 thanks

@codecov-commenter
Copy link

Codecov Report

Base: 90.09% // Head: 90.00% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (ee0b246) compared to base (25e9b59).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
- Coverage   90.09%   90.00%   -0.09%     
==========================================
  Files         117      108       -9     
  Lines        3605     3413     -192     
==========================================
- Hits         3248     3072     -176     
+ Misses        357      341      -16     
Impacted Files Coverage Δ
logging/lib/src/logging_integration.dart
logging/lib/src/extension.dart
dio/lib/src/breadcrumb_client_adapter.dart
dio/lib/src/dio_event_processor.dart
dio/lib/src/sentry_dio_extension.dart
dio/lib/src/failed_request_interceptor.dart
dio/lib/src/tracing_client_adapter.dart
dio/lib/src/sentry_transformer.dart
dio/lib/src/sentry_dio_client_adapter.dart

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto merged commit a45b9ed into getsentry:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants