-
-
Notifications
You must be signed in to change notification settings - Fork 255
Update dev deps #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev deps #1158
Conversation
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
691aa3b | 370.43 ms | 466.28 ms | 95.85 ms |
322aa66 | 284.98 ms | 341.76 ms | 56.78 ms |
eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
a49594a | 282.27 ms | 344.84 ms | 62.57 ms |
cdf7172 | 348.54 ms | 390.81 ms | 42.27 ms |
6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
870f5eb | 329.45 ms | 369.29 ms | 39.84 ms |
873fb42 | 352.10 ms | 397.43 ms | 45.33 ms |
5112c69 | 333.67 ms | 363.74 ms | 30.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
691aa3b | 5.94 MiB | 6.96 MiB | 1.02 MiB |
322aa66 | 5.94 MiB | 6.92 MiB | 1005.75 KiB |
eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
a49594a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
cdf7172 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
870f5eb | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
873fb42 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
5112c69 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7ade5af | 1296.24 ms | 1297.43 ms | 1.18 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
25e9b59 | 1289.76 ms | 1295.27 ms | 5.51 ms |
48e79fd | 1282.96 ms | 1296.12 ms | 13.17 ms |
9f9f94f | 1268.33 ms | 1284.73 ms | 16.41 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
633cf2e | 1257.96 ms | 1275.73 ms | 17.77 ms |
f922f8f | 1249.53 ms | 1266.51 ms | 16.98 ms |
0db91cc | 1267.63 ms | 1279.69 ms | 12.06 ms |
04db237 | 1273.29 ms | 1306.50 ms | 33.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7ade5af | 8.15 MiB | 9.15 MiB | 1015.93 KiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
25e9b59 | 8.16 MiB | 9.15 MiB | 1021.15 KiB |
48e79fd | 8.16 MiB | 9.15 MiB | 1021.87 KiB |
9f9f94f | 8.15 MiB | 9.15 MiB | 1020.76 KiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
633cf2e | 8.15 MiB | 9.12 MiB | 986.26 KiB |
f922f8f | 8.15 MiB | 9.13 MiB | 1003.20 KiB |
0db91cc | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
04db237 | 8.15 MiB | 9.13 MiB | 1003.16 KiB |
Codecov ReportBase: 90.08% // Head: 92.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
+ Coverage 90.08% 92.06% +1.97%
==========================================
Files 119 9 -110
Lines 3672 189 -3483
==========================================
- Hits 3308 174 -3134
+ Misses 364 15 -349 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
.github/workflows/flutter.yml
Outdated
- name: Upload coverage to Codecov | ||
if: runner.os == 'Linux' && matrix.sdk == 'stable' && matrix.target == 'linux' | ||
run: | | ||
curl -Os https://uploader.codecov.io/linux/latest/codecov | ||
chmod +x codecov | ||
./codecov -t ${CODECOV_TOKEN} -n sentry_flutter -f ./flutter/coverage/lcov.info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kahest can you add the CODECOV_TOKEN
to our repo?
This assumes that you've set your Codecov token inside Settings > Secrets as CODECOV_TOKEN. If not, you can get an upload token for your specific repo on codecov.io. Keep in mind that secrets are not available to forks of repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps