-
-
Notifications
You must be signed in to change notification settings - Fork 255
Missing slow and frozen frames for Auto transactions #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
a7acb24 | 301.00 ms | 357.38 ms | 56.38 ms |
abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
1c6eb5b | 350.69 ms | 393.86 ms | 43.17 ms |
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
870f5eb | 329.45 ms | 369.29 ms | 39.84 ms |
613760b | 373.42 ms | 399.33 ms | 25.92 ms |
aa950e9 | 337.42 ms | 400.72 ms | 63.30 ms |
ae02632 | 309.16 ms | 348.98 ms | 39.82 ms |
3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
a7acb24 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
1c6eb5b | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
870f5eb | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
613760b | 5.94 MiB | 6.92 MiB | 1005.98 KiB |
aa950e9 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
ae02632 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
Codecov ReportBase: 90.03% // Head: 88.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 90.03% 88.87% -1.17%
==========================================
Files 110 121 +11
Lines 3483 3810 +327
==========================================
+ Hits 3136 3386 +250
- Misses 347 424 +77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae02632 | 1286.77 ms | 1300.37 ms | 13.60 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
f922f8f | 1249.53 ms | 1266.51 ms | 16.98 ms |
aa950e9 | 1275.17 ms | 1295.33 ms | 20.16 ms |
f4cc744 | 1274.57 ms | 1290.79 ms | 16.22 ms |
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
6325c3b | 1266.52 ms | 1291.06 ms | 24.54 ms |
9f9f94f | 1268.33 ms | 1284.73 ms | 16.41 ms |
04db237 | 1273.29 ms | 1306.50 ms | 33.21 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae02632 | 8.16 MiB | 9.15 MiB | 1020.68 KiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
f922f8f | 8.15 MiB | 9.13 MiB | 1003.20 KiB |
aa950e9 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
f4cc744 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
6325c3b | 8.16 MiB | 9.17 MiB | 1.01 MiB |
9f9f94f | 8.15 MiB | 9.15 MiB | 1020.76 KiB |
04db237 | 8.15 MiB | 9.13 MiB | 1003.16 KiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
💡 Motivation and Context
Refactored a bit the functions with typedef.
💚 How did you test it?
Running it
📝 Checklist
🔮 Next steps