Skip to content

Bump Android emulator #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Bump Android emulator #1248

merged 2 commits into from
Jan 26, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 25, 2023

📜 Description

#skip-changelog

💡 Motivation and Context

https://github.com/getsentry/sentry-dart/actions/runs/4007392468/jobs/6880170046

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 90.70% // Head: 89.72% // Decreases project coverage by -0.98% ⚠️

Coverage data is based on head (257cb1e) compared to base (457a85b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   90.70%   89.72%   -0.98%     
==========================================
  Files         153      155       +2     
  Lines        4895     5033     +138     
==========================================
+ Hits         4440     4516      +76     
- Misses        455      517      +62     
Impacted Files Coverage Δ
file/lib/src/sentry_file.dart 54.13% <0.00%> (ø)
file/lib/src/sentry_file_extension.dart 80.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto enabled auto-merge (squash) January 25, 2023 16:28
@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.10 ms 460.29 ms 56.19 ms
Size 6.06 MiB 7.09 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a1a1545 295.21 ms 351.16 ms 55.95 ms
a609134 350.12 ms 404.12 ms 54.00 ms
7f2b01d 304.94 ms 345.71 ms 40.78 ms
5603ab2 309.84 ms 345.20 ms 35.36 ms
6957bfd 325.88 ms 380.30 ms 54.43 ms
48e79fd 354.22 ms 391.46 ms 37.24 ms
8d64376 302.88 ms 356.84 ms 53.96 ms
ecb4003 332.58 ms 385.15 ms 52.57 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
9f9f94f 331.04 ms 368.92 ms 37.88 ms

App size

Revision Plain With Sentry Diff
a1a1545 5.94 MiB 6.96 MiB 1.02 MiB
a609134 5.94 MiB 6.95 MiB 1.01 MiB
7f2b01d 5.94 MiB 6.95 MiB 1.01 MiB
5603ab2 5.94 MiB 6.95 MiB 1.01 MiB
6957bfd 5.94 MiB 6.95 MiB 1.01 MiB
48e79fd 5.94 MiB 6.95 MiB 1.01 MiB
8d64376 5.94 MiB 6.96 MiB 1.02 MiB
ecb4003 6.06 MiB 7.09 MiB 1.03 MiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
9f9f94f 5.94 MiB 6.95 MiB 1.01 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.04 ms 1271.94 ms 24.90 ms
Size 8.09 MiB 9.07 MiB 1001.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
322aa66 1251.68 ms 1275.52 ms 23.84 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
62dde43 1258.43 ms 1276.81 ms 18.38 ms
ccc09e4 1254.74 ms 1277.08 ms 22.34 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
1edf30e 1254.43 ms 1272.82 ms 18.39 ms
6957bfd 1283.80 ms 1289.00 ms 5.20 ms
cdf7172 1264.43 ms 1291.39 ms 26.96 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms

App size

Revision Plain With Sentry Diff
322aa66 8.15 MiB 9.12 MiB 992.53 KiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
62dde43 8.16 MiB 9.17 MiB 1.01 MiB
ccc09e4 8.16 MiB 9.16 MiB 1.01 MiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
1edf30e 8.16 MiB 9.17 MiB 1.01 MiB
6957bfd 8.15 MiB 9.15 MiB 1020.71 KiB
cdf7172 8.16 MiB 9.16 MiB 1.01 MiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB

@marandaneto marandaneto merged commit fa16e53 into main Jan 26, 2023
@marandaneto marandaneto deleted the bump/-android-emulator branch January 26, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants