Upgrade sentry dart plugin #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Mar 28, 2023
| @@ -42,10 +42,10 @@ flutter: | |||
| - assets/sentry-wordmark.png | |||
|
|
|||
| sentry: | |||
| upload_native_symbols: true | |||
There was a problem hiding this comment.
Already enabled by default
marandaneto
commented
Mar 28, 2023
| upload_source_maps: true | ||
| include_native_sources: true | ||
| upload_sources: true |
marandaneto
commented
Mar 28, 2023
| project: sentry-flutter | ||
| org: sentry-sdks | ||
| wait_for_processing: true | ||
| commits: true | ||
| ignore_missing: true |
There was a problem hiding this comment.
Because of squash/merge and commits:true
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 89.90% 91.03% +1.13%
==========================================
Files 179 160 -19
Lines 5755 5122 -633
==========================================
- Hits 5174 4663 -511
+ Misses 581 459 -122 see 19 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
| 3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
| 134c9f8 | 301.40 ms | 352.65 ms | 51.26 ms |
| aa950e9 | 337.42 ms | 400.72 ms | 63.30 ms |
| 49a149b | 301.96 ms | 344.51 ms | 42.55 ms |
| 8a7f528 | 290.27 ms | 341.80 ms | 51.53 ms |
| 0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
| 90db9ff | 334.86 ms | 388.14 ms | 53.28 ms |
| 3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
| e5b744f | 302.70 ms | 342.17 ms | 39.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
| 3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 134c9f8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| aa950e9 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 49a149b | 5.94 MiB | 6.92 MiB | 1001.54 KiB |
| 8a7f528 | 6.06 MiB | 7.03 MiB | 989.36 KiB |
| 0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 90db9ff | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| e5b744f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
| 6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
| 3f23617 | 1261.93 ms | 1286.10 ms | 24.17 ms |
| 21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
| 873fb42 | 1261.00 ms | 1285.92 ms | 24.92 ms |
| 613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
| 49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
| aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
| ebfead1 | 1271.57 ms | 1284.48 ms | 12.91 ms |
| 08a7b4f | 1277.10 ms | 1303.37 ms | 26.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
| 3f23617 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
| 873fb42 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
| 49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| ebfead1 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 08a7b4f | 8.16 MiB | 9.16 MiB | 1.01 MiB |
brustolin
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps