-
-
Notifications
You must be signed in to change notification settings - Fork 255
Upgrade ktlint #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Upgrade ktlint #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
- Coverage 90.98% 90.25% -0.73%
==========================================
Files 61 181 +120
Lines 2019 5779 +3760
==========================================
+ Hits 1837 5216 +3379
- Misses 182 563 +381 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e66e71e | 296.84 ms | 345.43 ms | 48.59 ms |
0be962b | 325.54 ms | 382.83 ms | 57.29 ms |
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
24f71aa | 358.49 ms | 455.90 ms | 97.41 ms |
0a82a1e | 321.02 ms | 393.82 ms | 72.80 ms |
7f2b01d | 304.94 ms | 345.71 ms | 40.78 ms |
f2db4ec | 372.46 ms | 469.72 ms | 97.26 ms |
ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
519423f | 357.00 ms | 415.77 ms | 58.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e66e71e | 6.06 MiB | 7.09 MiB | 1.03 MiB |
0be962b | 6.06 MiB | 7.03 MiB | 990.29 KiB |
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
24f71aa | 6.06 MiB | 7.03 MiB | 990.30 KiB |
0a82a1e | 6.15 MiB | 7.11 MiB | 981.82 KiB |
7f2b01d | 5.94 MiB | 6.95 MiB | 1.01 MiB |
f2db4ec | 6.06 MiB | 7.03 MiB | 990.27 KiB |
ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
519423f | 6.06 MiB | 7.03 MiB | 989.24 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
40680d3 | 1243.22 ms | 1257.02 ms | 13.80 ms |
2f8f173 | 1280.61 ms | 1292.20 ms | 11.59 ms |
eecbbca | 1264.90 ms | 1286.33 ms | 21.43 ms |
c73ab67 | 1267.73 ms | 1279.36 ms | 11.63 ms |
7f2b01d | 1253.92 ms | 1266.70 ms | 12.78 ms |
6572f8d | 1242.16 ms | 1246.63 ms | 4.47 ms |
d7758e8 | 1271.69 ms | 1288.08 ms | 16.39 ms |
3a43905 | 1254.31 ms | 1266.35 ms | 12.04 ms |
56810ff | 1267.59 ms | 1293.48 ms | 25.89 ms |
a817b8f | 1261.90 ms | 1264.62 ms | 2.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
40680d3 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
2f8f173 | 8.15 MiB | 9.13 MiB | 1000.39 KiB |
eecbbca | 8.15 MiB | 9.10 MiB | 965.26 KiB |
c73ab67 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
7f2b01d | 8.16 MiB | 9.16 MiB | 1.00 MiB |
6572f8d | 8.29 MiB | 9.36 MiB | 1.07 MiB |
d7758e8 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
3a43905 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
56810ff | 8.15 MiB | 9.12 MiB | 987.35 KiB |
a817b8f | 8.29 MiB | 9.37 MiB | 1.07 MiB |
stefanosiano
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
💡 Motivation and Context
Exception in thread "main" picocli.CommandLine$UnmatchedArgumentException: Unknown option: '--android'
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps