Skip to content

Upgrade ktlint #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Upgrade ktlint #1542

merged 4 commits into from
Jul 11, 2023

Conversation

marandaneto
Copy link
Contributor

📜 Description

#skip-changelog

💡 Motivation and Context

Exception in thread "main" picocli.CommandLine$UnmatchedArgumentException: Unknown option: '--android'

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.73 ⚠️

Comparison is base (84a3369) 90.98% compared to head (3990945) 90.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   90.98%   90.25%   -0.73%     
==========================================
  Files          61      181     +120     
  Lines        2019     5779    +3760     
==========================================
+ Hits         1837     5216    +3379     
- Misses        182      563     +381     

see 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 303.18 ms 360.32 ms 57.14 ms
Size 6.16 MiB 7.14 MiB 1003.99 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e66e71e 296.84 ms 345.43 ms 48.59 ms
0be962b 325.54 ms 382.83 ms 57.29 ms
2f8f173 323.31 ms 373.29 ms 49.97 ms
24f71aa 358.49 ms 455.90 ms 97.41 ms
0a82a1e 321.02 ms 393.82 ms 72.80 ms
7f2b01d 304.94 ms 345.71 ms 40.78 ms
f2db4ec 372.46 ms 469.72 ms 97.26 ms
ef31c7f 311.39 ms 359.33 ms 47.94 ms
08a7b4f 346.47 ms 403.29 ms 56.82 ms
519423f 357.00 ms 415.77 ms 58.77 ms

App size

Revision Plain With Sentry Diff
e66e71e 6.06 MiB 7.09 MiB 1.03 MiB
0be962b 6.06 MiB 7.03 MiB 990.29 KiB
2f8f173 5.94 MiB 6.95 MiB 1.01 MiB
24f71aa 6.06 MiB 7.03 MiB 990.30 KiB
0a82a1e 6.15 MiB 7.11 MiB 981.82 KiB
7f2b01d 5.94 MiB 6.95 MiB 1.01 MiB
f2db4ec 6.06 MiB 7.03 MiB 990.27 KiB
ef31c7f 6.06 MiB 7.09 MiB 1.03 MiB
08a7b4f 5.94 MiB 6.95 MiB 1.01 MiB
519423f 6.06 MiB 7.03 MiB 989.24 KiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.86 ms 1244.33 ms 9.47 ms
Size 8.29 MiB 9.37 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
40680d3 1243.22 ms 1257.02 ms 13.80 ms
2f8f173 1280.61 ms 1292.20 ms 11.59 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
c73ab67 1267.73 ms 1279.36 ms 11.63 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms
6572f8d 1242.16 ms 1246.63 ms 4.47 ms
d7758e8 1271.69 ms 1288.08 ms 16.39 ms
3a43905 1254.31 ms 1266.35 ms 12.04 ms
56810ff 1267.59 ms 1293.48 ms 25.89 ms
a817b8f 1261.90 ms 1264.62 ms 2.73 ms

App size

Revision Plain With Sentry Diff
40680d3 8.10 MiB 9.16 MiB 1.07 MiB
2f8f173 8.15 MiB 9.13 MiB 1000.39 KiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
c73ab67 8.29 MiB 9.36 MiB 1.07 MiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB
6572f8d 8.29 MiB 9.36 MiB 1.07 MiB
d7758e8 8.15 MiB 9.12 MiB 989.76 KiB
3a43905 8.10 MiB 9.18 MiB 1.08 MiB
56810ff 8.15 MiB 9.12 MiB 987.35 KiB
a817b8f 8.29 MiB 9.37 MiB 1.07 MiB

@marandaneto marandaneto enabled auto-merge (squash) July 10, 2023 12:22
@marandaneto marandaneto merged commit 1596141 into main Jul 11, 2023
@marandaneto marandaneto deleted the chore/upgrade-ktlint branch July 11, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants