Ensure Breadcrumbs and SentryEvents are always serialisable

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Ensure Breadcrumbs and SentryEvents are always serialisable ([#1582](https://github.com/getsentry/sentry-dart/pull/1582))
+
 ## 7.9.0
 
 ### Features

logging/lib/src/extension.dart

@@ -12,9 +12,9 @@ extension LogRecordX on LogRecord {
       level: level.toSentryLevel(),
       message: message,
       data: <String, Object>{
-        if (object != null) 'LogRecord.object': object!,
-        if (error != null) 'LogRecord.error': error!,
-        if (stackTrace != null) 'LogRecord.stackTrace': stackTrace!,
+        if (object != null) 'LogRecord.object': object!.toString(),
+        if (error != null) 'LogRecord.error': error!.toString(),
+        if (stackTrace != null) 'LogRecord.stackTrace': stackTrace!.toString(),
         'LogRecord.loggerName': loggerName,
         'LogRecord.sequenceNumber': sequenceNumber,
       },
@@ -30,7 +30,7 @@ extension LogRecordX on LogRecord {
       throwable: error,
       // ignore: deprecated_member_use
       extra: <String, Object>{
-        if (object != null) 'LogRecord.object': object!,
+        if (object != null) 'LogRecord.object': object!.toString(),
         'LogRecord.sequenceNumber': sequenceNumber,
       },
     );

logging/test/extension_test.dart

@@ -2,6 +2,10 @@ import 'package:logging/logging.dart';
 import 'package:sentry_logging/src/extension.dart';
 import 'package:test/test.dart';
 
+class _TestObject {}
+
+class _TestErrorObject {}
+
 void main() {
   test('breadcrumb time is always utc', () {
     final log = LogRecord(Level.CONFIG, 'foo bar', 'test logger');
@@ -14,4 +18,41 @@ void main() {
 
     expect(log.toEvent().timestamp?.isUtc, true);
   });
+
+  test('user defined objects are converted to string', () {
+    // Every value in the data and extra map must be convertible to by the
+    // StandardMessageCodec. We convert all user supplied types and the
+    // StackTrace to a string to make this property hold.
+
+    final object = _TestObject();
+    final error = _TestErrorObject();
+    final stackTrace = StackTrace.current;
+
+    final log = LogRecord(
+      Level.CONFIG,
+      'foo bar',
+      'test logger',
+      error,
+      stackTrace,
+      null,
+      object,
+    );
+
+    final breadcrumb = log.toBreadcrumb();
+    expect(
+      breadcrumb.data,
+      containsPair('LogRecord.object', object.toString()),
+    );
+    expect(
+      log.toBreadcrumb().data,
+      containsPair('LogRecord.stackTrace', stackTrace.toString()),
+    );
+
+    final event = log.toEvent();
+    expect(
+      // ignore: deprecated_member_use
+      event.extra,
+      containsPair('LogRecord.object', object.toString()),
+    );
+  });
 }