Skip to content

Update root name #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Unreleased

## Features
### Features

- Add TTFD (time to full display), which allows you to measure the time it takes to render the full screen ([#1920](https://github.com/getsentry/sentry-dart/pull/1920))
- Requires using the [routing instrumentation](https://docs.sentry.io/platforms/flutter/integrations/routing-instrumentation/).
Expand All @@ -23,6 +23,11 @@
- The `dio` integration and `SentryHttpClient` now take an additional `captureFailedRequests` option.
- This is useful if you want to disable this option on native and only enable it on `dio` for example.

### Improvements

- Update root name for navigator observer ([#1934](https://github.com/getsentry/sentry-dart/pull/1934))
- The root name for transactions is now `root /` instead of `root ("/")`.

### Dependencies

- Bump Android SDK from v7.5.0 to v7.6.0 ([#1927](https://github.com/getsentry/sentry-dart/pull/1927))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
}

if (name == '/') {
name = 'root ("/")';
name = 'root /';
}
final transactionContext = SentryTransactionContext(
name,
Expand Down
2 changes: 1 addition & 1 deletion flutter/test/navigation/sentry_display_widget_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ void main() {
expect(ttidSpan.context.operation,
SentrySpanOperations.uiTimeToInitialDisplay);
expect(ttidSpan.finished, isTrue);
expect(ttidSpan.context.description, 'root ("/") initial display');
expect(ttidSpan.context.description, 'root / initial display');
expect(ttidSpan.origin, SentryTraceOrigins.autoUiTimeToDisplay);

expect(ttidSpan.startTimestamp, appStartInfo.start);
Expand Down
2 changes: 1 addition & 1 deletion flutter/test/sentry_navigator_observer_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ void main() {
onFinish: anyNamed('onFinish'),
)).captured.single as SentryTransactionContext;

expect(context.name, 'root ("/")');
expect(context.name, 'root /');

hub.configureScope((scope) {
expect(scope.span, span);
Expand Down