-
-
Notifications
You must be signed in to change notification settings - Fork 255
fix: event processor blocking transactions from being sent if autoAppStart
is false
#2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoAppStart
is falseautoAppStart
is false
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5cc82a0 | 400.35 ms | 474.52 ms | 74.17 ms |
0bed04d | 382.15 ms | 458.33 ms | 76.18 ms |
72dfc83 | 298.62 ms | 340.14 ms | 41.52 ms |
deaeece | 347.42 ms | 381.10 ms | 33.68 ms |
8e133ad | 360.08 ms | 402.82 ms | 42.74 ms |
dd1f7d2 | 338.54 ms | 387.10 ms | 48.56 ms |
5aa047a | 329.45 ms | 403.18 ms | 73.73 ms |
26e955b | 369.52 ms | 458.60 ms | 89.07 ms |
d53c6fa | 282.83 ms | 344.00 ms | 61.17 ms |
8fa3934 | 340.64 ms | 407.92 ms | 67.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5cc82a0 | 6.34 MiB | 7.28 MiB | 966.66 KiB |
0bed04d | 6.33 MiB | 7.30 MiB | 987.71 KiB |
72dfc83 | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
deaeece | 5.94 MiB | 6.96 MiB | 1.02 MiB |
8e133ad | 6.06 MiB | 7.03 MiB | 990.29 KiB |
dd1f7d2 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
5aa047a | 6.16 MiB | 7.14 MiB | 1011.25 KiB |
26e955b | 6.27 MiB | 7.20 MiB | 956.49 KiB |
d53c6fa | 6.16 MiB | 7.14 MiB | 1011.18 KiB |
8fa3934 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
stefanosiano
reviewed
May 6, 2024
stefanosiano
reviewed
May 6, 2024
@stefanosiano we might have to release this fix on the v7 branch as well since it affects it too |
stefanosiano
approved these changes
May 6, 2024
buenaflor
added a commit
that referenced
this pull request
May 8, 2024
…pStart` is false (#2028) * Add fix * Update CHANGELOG * Fix tests * Update native_app_start_integration.dart * Implement code review * Apply auto ttid only when autoAppStart is true * Revert * Revert
6 tasks
buenaflor
added a commit
that referenced
this pull request
May 10, 2024
…sabled (#2045) * fix: event processor blocking transactions from being sent if `autoAppStart` is false (#2028) * Add fix * Update CHANGELOG * Fix tests * Update native_app_start_integration.dart * Implement code review * Apply auto ttid only when autoAppStart is true * Revert * Revert * Update CHANGELOG * Update * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
if
autoAppStart
is false then the Future wats forAppStartInfo
forever💡 Motivation and Context
Fixes #2007
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps