Skip to content

block app start if appLaunchedInForeground is not set. #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 23, 2024
Merged

block app start if appLaunchedInForeground is not set. #2291

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cd9bdd5
block app start if appLaunchedInForeground is not set.
martinhaintz Sep 16, 2024
e71db34
add changelog entry
martinhaintz Sep 16, 2024
b2dc712
call public method
martinhaintz Sep 16, 2024
cf64268
Merge branch 'main' into feat/use-app-launched-in-foreground-to-deter…
martinhaintz Sep 16, 2024
7067094
fix deprecated toUpperCase to uppercase
martinhaintz Sep 17, 2024
fad381e
Merge branch 'feat/use-app-launched-in-foreground-to-determinate-inva…
martinhaintz Sep 17, 2024
1510a65
Merge branch 'main' into feat/use-app-launched-in-foreground-to-deter…
martinhaintz Sep 17, 2024
9ccfd74
Update flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutte…
martinhaintz Sep 23, 2024
0efe121
Merge branch 'main' into feat/use-app-launched-in-foreground-to-deter…
martinhaintz Sep 23, 2024
4248571
add 60 second timeout for app starts for android native
martinhaintz Sep 23, 2024
4f9b01c
fix missing time imports
martinhaintz Sep 23, 2024
8f47758
rearrange line
martinhaintz Sep 23, 2024
6eb6ab6
add comma
martinhaintz Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Features

- Blocking app starts if "appLaunchedInForeground" is false. (Android only) ([#2291](https://github.com/getsentry/sentry-dart/pull/2291)

### Enhancements

- Improve app start integration ([#2266](https://github.com/getsentry/sentry-dart/pull/2266))
Expand Down
2 changes: 1 addition & 1 deletion flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class SentryFlutter(
}
data.getIfNotNull<String>("diagnosticLevel") {
if (options.isDebug) {
val sentryLevel = SentryLevel.valueOf(it.toUpperCase(Locale.ROOT))
val sentryLevel = SentryLevel.valueOf(it.uppercase(Locale.ROOT))
options.setDiagnosticLevel(sentryLevel)
}
}
Expand Down
5 changes: 5 additions & 0 deletions flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,11 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {

val appStartMetrics = AppStartMetrics.getInstance()

if (!appStartMetrics.isAppLaunchedInForeground) {
Log.w("Sentry", "App not launched in Foreground")
result.success(null)
}

val appStartTimeSpan = appStartMetrics.appStartTimeSpan
val appStartTime = appStartTimeSpan.startTimestamp
val isColdStart = appStartMetrics.appStartType == AppStartMetrics.AppStartType.COLD
Expand Down
Loading