-
-
Notifications
You must be signed in to change notification settings - Fork 257
Disable ScreenshotIntegration
, WidgetsBindingIntegration
and SentryWidget
in multi-view apps
#2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1b36c56
add multiview helper to make the sentry widget, multiview aware.
martinhaintz f6239fb
switch to implicit view approach
martinhaintz 36a84aa
add changelog
martinhaintz 540d1c0
make it flutter 3.0.0 compatible
martinhaintz 1dab88e
fix exception
martinhaintz 179091d
fix exception
martinhaintz 3e8ab97
remove unused platform code
martinhaintz 4f8cb52
automatically disable WidgetsBindingIntegration() for multiview
martinhaintz 218975a
add debug message, if not available
martinhaintz 0dbce52
fix `WidgetsBindingIntegration` call
martinhaintz 9e610e4
fix, screenshotIntegration call
martinhaintz cae9153
Merge branch 'main' into feat/multiview-aware
martinhaintz 481b982
Update CHANGELOG.md
martinhaintz 55c4790
Move MultiViewCheck for WidgetsBindingIntegration inside object
martinhaintz f0e82e4
Move MultiViewCheck for ScreenshotIntegration inside object
martinhaintz d52c4fe
move platform dispatcher wrapper in a separate file
martinhaintz addcc64
Merge branch 'main' into feat/multiview-aware
martinhaintz 11fc266
Merge branch 'main' into feat/multiview-aware
denrase c92c8de
Merge branch 'main' into feat/multiview-aware
denrase be2b2de
move multiview check to init
denrase df169ab
move back to integrations/widget and add tests
denrase 0e36b03
update cl entry
denrase e037114
fix analyzer issues
denrase b228520
move wrapper to own file to fix analyzer warnign
denrase 1d57db2
use onerror cb
denrase 2baf2a4
Merge branch 'main' into feat/multiview-aware
denrase 728ee2e
fix cl
denrase 34a6145
add test
denrase 55eb500
Merge branch 'main' into feat/multiview-aware
denrase 72556e0
fix cl
denrase bc5c2e1
don’t test for screenshot integration
denrase bb385c5
fix test
denrase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import 'dart:ui'; | ||
import 'package:meta/meta.dart'; | ||
|
||
@internal | ||
class MultiViewHelper { | ||
static bool isMultiViewEnabled() { | ||
final dynamic uncheckedImplicitView = PlatformDispatcher.instance; | ||
try { | ||
return null == uncheckedImplicitView.implicitView; | ||
} on NoSuchMethodError catch (_) { | ||
return false; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.