Skip to content

Release: Update READMEs for v4 GA #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 10, 2020
Merged

Release: Update READMEs for v4 GA #239

merged 5 commits into from
Dec 10, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Dec 10, 2020 •
edited
Loading

No description provided.

@marandaneto marandaneto requested a review from a team December 10, 2020 13:22
@codecov-io
Copy link

codecov-io commented Dec 10, 2020 •
edited
Loading

Codecov Report

Merging #239 (f446a9c) into main (dd380f2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files          52       52           
  Lines        1729     1729           
=======================================
  Hits         1499     1499           
  Misses        230      230
Impacted Files Coverage Δ
dart/lib/src/version.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd380f2...f446a9c. Read the comment docs.

bruno-garcia
bruno-garcia approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is beautiful to read.
I added one note and a suggestion

@marandaneto marandaneto merged commit ffcfde2 into main Dec 10, 2020
@marandaneto marandaneto deleted the release/v4-ga branch December 10, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @codecov-io @bruno-garcia