[v9]: Replace custom Platform & PlatformChecker with package platform #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Replace custom Platform & PlatformChecker with package platform ([#2729](https://github.com/getsentry/sentry-dart/pull/2729))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2729 +/- ##
==========================================
- Coverage 88.62% 87.05% -1.57%
==========================================
Files 263 121 -142
Lines 8761 4157 -4604
==========================================
- Hits 7764 3619 -4145
+ Misses 997 538 -459 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can we close this? @denrase |
|
@buenaflor Let me merge in v9 and then we can. |
# Conflicts: # dart/lib/src/platform/_io_platform.dart # dart/lib/src/platform/_web_platform.dart # dart/lib/src/platform/platform.dart # dart/lib/src/runtime_checker.dart # dart/test/mocks/mock_platform.dart # dart/test/mocks/mock_platform_checker.dart # flutter/test/mocks.dart # flutter/test/profiling_test.dart # flutter/test/sentry_flutter_test.dart # flutter/test/sentry_native_channel_test.dart
|
@buenaflor Ah, though this was another PR. This is will not be implementd, yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Replace Platform
💡 Motivation and Context
Relates to #2646
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps