-
-
Notifications
You must be signed in to change notification settings - Fork 256
Upgrade dependencies (http 0.13.0
etc) for Flutter 2 upgrade
#339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lutter 2 release!
Codecov Report
@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 86.64% 80.97% -5.67%
==========================================
Files 52 5 -47
Lines 1759 226 -1533
==========================================
- Hits 1524 183 -1341
+ Misses 235 43 -192 Continue to review full report at Codecov.
|
I think, this is unneeded since these changes have already been applied to the null-safety branch: https://github.com/getsentry/sentry-dart/tree/feat/null-safety |
@ThexXTURBOXx thnx for your reply. However, I've few comments;
The maintainers are free to reject/close this PR if they still think it is unnecessary. My apps require those updates asap, thus looking forward for your branch to be published. |
No problem, I am not a contributor to this project, but I have some advice for the time being :) To fix all your problems for now, just use a |
ah I see! Then let's wait for the ultimate assessment of the maintainers :) |
📜 Description
Upgrade dependencies (
http 0.13.0
etc) as it is widely used after Flutter 2 release!💡 Motivation and Context
After Flutter2 release,
http 0.13.0
is the preferred version used by many developers.Sentry
package dependencies required to be up2date to meet this demand.💚 How did you test it?
My apps which have the latest and greatest package versions began failing caused by the issue as described in #338 . The updates in this PR resolves it.
📝 Checklist
🔮 Next steps
Review and publish a new release after merge