Skip to content

Upgrade dependencies (http 0.13.0 etc) for Flutter 2 upgrade #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

zeusbaba
Copy link

@zeusbaba zeusbaba commented Mar 5, 2021

📜 Description

Upgrade dependencies (http 0.13.0 etc) as it is widely used after Flutter 2 release!

💡 Motivation and Context

After Flutter2 release, http 0.13.0 is the preferred version used by many developers. Sentry package dependencies required to be up2date to meet this demand.

💚 How did you test it?

My apps which have the latest and greatest package versions began failing caused by the issue as described in #338 . The updates in this PR resolves it.

📝 Checklist

  • [ x ] I reviewed submitted code
  • [ x ] I added tests to verify changes
  • [ x ] I updated the docs if needed
  • [ x ] All tests passing
  • [ x ] No breaking changes

🔮 Next steps

Review and publish a new release after merge

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #339 (4a4fa60) into main (00a266c) will decrease coverage by 5.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   86.64%   80.97%   -5.67%     
==========================================
  Files          52        5      -47     
  Lines        1759      226    -1533     
==========================================
- Hits         1524      183    -1341     
+ Misses        235       43     -192     
Impacted Files Coverage Δ
dart/lib/src/protocol/operating_system.dart
dart/lib/src/protocol/request.dart
dart/lib/src/sentry.dart
dart/lib/src/protocol/sentry_stack_frame.dart
dart/lib/src/protocol/sdk_version.dart
dart/lib/src/protocol/debug_meta.dart
dart/lib/src/diagnostic_logger.dart
dart/lib/src/sentry_options.dart
dart/lib/src/protocol/app.dart
dart/lib/src/hub_adapter.dart
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a266c...4a4fa60. Read the comment docs.

@ThexXTURBOXx
Copy link
Contributor

I think, this is unneeded since these changes have already been applied to the null-safety branch: https://github.com/getsentry/sentry-dart/tree/feat/null-safety

@zeusbaba
Copy link
Author

zeusbaba commented Mar 5, 2021

@ThexXTURBOXx thnx for your reply. However, I've few comments;

  • naturally, I didn't know about the active branches, for I'm new contributor :)
  • the lack of http 0.13.0... broke my apps, therefore I need this fix asap
  • my first PR is an attempt to fix things iteratively

The maintainers are free to reject/close this PR if they still think it is unnecessary.

My apps require those updates asap, thus looking forward for your branch to be published.

@ThexXTURBOXx
Copy link
Contributor

No problem, I am not a contributor to this project, but I have some advice for the time being :)

To fix all your problems for now, just use a dependency_override with either your own repo or the null_safety branch here. I don't think, it will take too long until the breaking change will be released as a pre release of version 5.0.0 as many people will need this update now.

@zeusbaba
Copy link
Author

zeusbaba commented Mar 5, 2021

No problem, I am not a contributor to this project, but I have some advice for the time being :)

To fix all your problems for now, just use a dependency_override with either your own repo or the null_safety branch here. I don't think, it will take too long until the breaking change will be released as a pre release of version 5.0.0 as many people will need this update now.

ah I see! Then let's wait for the ultimate assessment of the maintainers :)

@marandaneto
Copy link
Contributor

@zeusbaba thank you so much for that, but as stated by @ThexXTURBOXx this part has already been migrated #335 thanks to @ueman and #337 is on its way by @fzyzcjy

@marandaneto marandaneto closed this Mar 6, 2021
@zeusbaba
Copy link
Author

zeusbaba commented Mar 6, 2021

@zeusbaba thank you so much for that, but as stated by @ThexXTURBOXx this part has already been migrated #335 thanks to @ueman and #337 is on its way by @fzyzcjy

Thanks for your feedback.
Sure, looking forward for your release of new version.

@ThexXTURBOXx ThexXTURBOXx mentioned this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants