Fix: Enabled breadcrumb recording mechanism based on platform #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Mar 16, 2021
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # Unreleased | |||
|
|
|||
| * Fix: Enable breadcrumb recording mechanism based on platform ((#366)) | |||
| * Remove deprecated member `enableLifecycleBreadcrumbs`. Use `enableAppLifecycleBreadcrumbs` instead. ((#366)) | |||
There was a problem hiding this comment.
let's move this one to the breaking change section in the changelog
There was a problem hiding this comment.
both entries have dup (( or ))
ueman
force-pushed
the
fix/enable-breadcrumbs-based-on-platform
branch
from
c2b55a1 to
3c9af26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This change enables the breadcrumb recording mechanism based on the platform.
It also removes the deprecated member
SentryFlutterOptions.enableLifecycleBreadcrumbs.I'm not sure if this is considered a breaking change.
💡 Motivation and Context
See #288
💚 How did you test it?
There are already tests which make sure that
SentryFlutterOptions.enableBreadcrumbTrackingForCurrentPlatform()works.📝 Checklist
🔮 Next steps