Fix: Set SentryOptions.debug in sentry
#376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are from #375 Edit: fixed by merging latest changes |
# Conflicts: # dart/lib/src/sentry.dart
3 tasks
marandaneto
reviewed
Mar 22, 2021
ueman
changed the title
SentryOptions.debug in sentry_dart (#376)SentryOptions.debug in sentry
marandaneto
approved these changes
Mar 22, 2021
Co-authored-by: Manoel Aranda Neto <[email protected]>
Codecov Report
@@ Coverage Diff @@
## fix/environment-variables #376 +/- ##
=============================================================
+ Coverage 90.25% 90.85% +0.60%
=============================================================
Files 52 52
Lines 1652 1652
=============================================================
+ Hits 1491 1501 +10
+ Misses 161 151 -10
Continue to review full report at Codecov.
|
`Instructions and example for changelog`$
To the changelog entry, please add a link to this PR (consider a more descriptive message):` - Set `SentryOptions.debug` in sentry(#376)
|
5 tasks
ueman
added a commit
that referenced
this pull request
Mar 29, 2021
* Correctly read environment variables * Changelog * Remove env vars from sentry_flutter * Docs & Changelog * Calm Linter * Hopefully fix failing tests * Implement PR feedback * Another try at fixing the failing tests * Update CHANGELOG.md Co-authored-by: Manoel Aranda Neto <[email protected]> * Fix: Set `SentryOptions.debug` in sentry (#376) * Fix: Set `SentryOptions.debug` in sentry_dart * Update CHANGELOG.md Co-authored-by: Manoel Aranda Neto <[email protected]> Co-authored-by: Manoel Aranda Neto <[email protected]> * Only override release and dist if not existing * Apply PR feedback * add teardown * Fix path * PR feedback Co-authored-by: Manoel Aranda Neto <[email protected]> Co-authored-by: Manoel Aranda Neto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This change sets
SentryOptions.debugin sentry_dart so it is available on all platforms/frameworks and not just Flutter.💡 Motivation and Context
#307
💚 How did you test it?
I added more
expectsto existing tests.📝 Checklist
🔮 Next steps