Skip to content

Allow attachments to be bound to exception more easily #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Allow attachments to be bound to exception more easily #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3028ffe
add `beforeCaptureWithScope` config
fzyzcjy Dec 26, 2021
03f23e5
fix import
fzyzcjy Dec 26, 2021
a162945
give more paramters to make it useful
fzyzcjy Dec 26, 2021
62f97e5
Merge branch 'getsentry:main' into main
fzyzcjy Apr 20, 2022
41f4b21
Merge branch 'main' of https://github.com/getsentry/sentry-dart into …
fzyzcjy May 13, 2022
1046aef
Merge remote-tracking branch 'origin/main'
fzyzcjy May 13, 2022
9454953
Merge remote-tracking branch 'upstream/main'
fzyzcjy Sep 11, 2022
9896b62
fix compile error
fzyzcjy Sep 11, 2022
47690cc
format code
fzyzcjy Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions dart/lib/src/hub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,15 @@ class Hub {
);
} else {
final item = _peek();
final scope = await _cloneAndRunWithScope(item.scope, withScope);
var scope = await _cloneAndRunWithScope(item.scope, withScope);

try {
if (_options.isTracingEnabled()) {
event = _assignTraceContext(event);
}

scope = await _applyOptionsBeforeCaptureWithScope(scope, event);

sentryId = await item.client.captureEvent(
event,
stackTrace: stackTrace,
Expand Down Expand Up @@ -129,7 +131,7 @@ class Hub {
);
} else {
final item = _peek();
final scope = await _cloneAndRunWithScope(item.scope, withScope);
var scope = await _cloneAndRunWithScope(item.scope, withScope);

try {
var event = SentryEvent(
Expand All @@ -141,6 +143,8 @@ class Hub {
event = _assignTraceContext(event);
}

scope = await _applyOptionsBeforeCaptureWithScope(scope, event);

sentryId = await item.client.captureEvent(
event,
stackTrace: stackTrace,
Expand Down Expand Up @@ -185,7 +189,8 @@ class Hub {
);
} else {
final item = _peek();
final scope = await _cloneAndRunWithScope(item.scope, withScope);
var scope = await _cloneAndRunWithScope(item.scope, withScope);
scope = await _applyOptionsBeforeCaptureWithScope(scope, null);

try {
sentryId = await item.client.captureMessage(
Expand Down Expand Up @@ -248,6 +253,15 @@ class Hub {
return scope;
}

Future<Scope> _applyOptionsBeforeCaptureWithScope(
Scope scope, SentryEvent? event) {
return _cloneAndRunWithScope(
scope,
_options.beforeCaptureWithScope == null
? null
: (scope) => _options.beforeCaptureWithScope!(scope, event));
}

/// Adds a breacrumb to the current Scope
Future<void> addBreadcrumb(Breadcrumb crumb, {dynamic hint}) async {
if (!_isEnabled) {
Expand Down
5 changes: 5 additions & 0 deletions dart/lib/src/sentry_options.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,9 @@ class SentryOptions {
/// to be sent to Sentry.
TracesSamplerCallback? tracesSampler;

/// callback before capturing exceptions or events
BeforeCaptureWithScopeCallback? beforeCaptureWithScope;

/// Send statistics to sentry when the client drops events.
bool sendClientReports = true;

Expand Down Expand Up @@ -376,6 +379,8 @@ typedef SentryLogger = void Function(
typedef TracesSamplerCallback = double? Function(
SentrySamplingContext samplingContext);

typedef BeforeCaptureWithScopeCallback = void Function(Scope, SentryEvent?);

/// A NoOp logger that does nothing
void noOpLogger(
SentryLevel level,
Expand Down