Skip to content

Fix SentryAssetBundle on Flutter > 3.1 #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jun 6, 2022

📜 Description

Fix #875

💡 Motivation and Context

Fix #875

💚 How did you test it?

New test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #877 (7c33cae) into main (b1f0ff6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files         102      102           
  Lines        3146     3146           
=======================================
  Hits         2824     2824           
  Misses        322      322           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f0ff6...7c33cae. Read the comment docs.

@ueman ueman changed the title Fix SentryAssetBundle on Flutter >= 3.1 Fix SentryAssetBundle on Flutter > 3.1 Jun 6, 2022
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit f55626a into getsentry:main Jun 7, 2022
@ueman ueman deleted the feature/asset-bundle branch June 7, 2022 12:23
@ueman ueman mentioned this pull request Sep 1, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: The non-abstract class 'SentryAssetBundle' is missing implementations for these members:
4 participants