Skip to content

Breadcrumbs should not be duplicated if there is no mechaism on Android #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 7, 2022

📜 Description

Breadcrumbs should not be duplicated if there is no mechaism on Android

💡 Motivation and Context

Found by debugging, breadcrumbs were duplicated if there were no mechanism.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto requested a review from brustolin as a code owner July 7, 2022 09:30
@marandaneto marandaneto requested a review from denrase July 7, 2022 09:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #936 (d50bd7b) into main (3f0e852) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files           9        9           
  Lines         169      169           
=======================================
  Hits          152      152           
  Misses         17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0e852...d50bd7b. Read the comment docs.

@marandaneto marandaneto enabled auto-merge (squash) July 7, 2022 12:42
@marandaneto marandaneto merged commit 46626ac into main Jul 7, 2022
@marandaneto marandaneto deleted the fix/dup-crumbs-android branch July 7, 2022 13:41
marandaneto added a commit that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants