Skip to content

feat: Update node getting started pages #10164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2024
Merged

feat: Update node getting started pages #10164

merged 2 commits into from
May 28, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 27, 2024

This updates the getting started page for all node docs to use the new product selector.

I actually extracted the page out into an include because they all (fastify, express, node, ...) share the same content, so this is much easier to update.

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:33am

Copy link

codecov bot commented May 27, 2024

Bundle Report

Changes will increase total bundle size by 196 bytes ⬆️

Bundle name Size Change
sentry-docs-server 7.43MB 201 bytes ⬆️
sentry-docs-edge-server 461.86kB 3 bytes ⬇️
sentry-docs-client 6.19MB 2 bytes ⬇️

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Node looks pretty easy, browser is more spicy. Crazy how much duplication we had.

@mydea mydea force-pushed the fn/js-onboarding branch from 75d31ea to 638622f Compare May 28, 2024 07:15
@mydea mydea merged commit 6fafa5a into master May 28, 2024
6 checks passed
@mydea mydea deleted the fn/js-onboarding branch May 28, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants