Skip to content

fix(dart): beforeSend code snippet #11197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix(dart): beforeSend code snippet #11197

merged 3 commits into from
Sep 25, 2024

Conversation

buenaflor
Copy link
Contributor

Current code snippet example doesn't compile in dart

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Current code snippet example doesn't compile in dart
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 9:39pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 9:39pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 9:39pm

Copy link

codecov bot commented Sep 2, 2024

Bundle Report

Changes will increase total bundle size by 15.17MB (107.37%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
sentry-docs-server* 8.37MB 8.37MB (100%) ⬆️⚠️
sentry-docs-edge-server* 254.34kB 254.34kB (100%) ⬆️⚠️
sentry-docs-client* 6.39MB 6.39MB (100%) ⬆️⚠️
sentry-docs-server-cjs 7.6MB 154.81kB (2.08%) ⬆️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

@getsantry
Copy link
Contributor

getsantry bot commented Sep 25, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 25, 2024
@buenaflor buenaflor removed the Stale label Sep 25, 2024
@buenaflor
Copy link
Contributor Author

@kahest could you check why the deployment is failing, are there logs?

@kahest
Copy link
Member

kahest commented Sep 25, 2024

@buenaflor I think this #11436 fixes the changelog issue - we need to merge it in and then it should deploy

@buenaflor
Copy link
Contributor Author

got it, thx!

@buenaflor buenaflor merged commit c62ba9d into master Sep 25, 2024
10 checks passed
@buenaflor buenaflor deleted the buenaflor-patch-1 branch September 25, 2024 22:02
martinhaintz pushed a commit that referenced this pull request Oct 1, 2024
* master: (121 commits)
  Bump API schema to 1ce35106 (#11467)
  Bump API schema to fe37a3fa (#11465)
  Bump API schema to e9717315 (#11464)
  fix(remix): Add verify step to manual guide (#11463)
  Bump API schema to ff5880ca (#11457)
  docs(cron): Add note about luxon timezones (#11451)
  Bump API schema to f0e51113 (#11454)
  Add User Feedback alerts to main Alerts docs page (#11446)
  fix: Bun import (#11450)
  Bump API schema to d8309de0 (#11447)
  Update Intro to Sentry page (#11443)
  fix(releases): Document `release:latest` filter behaviour (#11423)
  Bump API schema to d6663c91 (#11442)
  feat(js): Document dataloaderIntegration released with 8.31.0 (#11416)
  docs(go): Add custom instrumentation page for tracing (#11429)
  ref(onboarding): Update word (#11440)
  feat(nuxt): Update server setup docs (#11415)
  Update docs on running getsentry locally (#11428)
  Callout to add .env to .gitignore #11430
  fix(dart): beforeSend code snippet (#11197)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants