Skip to content

fix(platform): Enable scrolling via keyboard buttons #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jan 24, 2025

Enables scrolling with keyboard arrow keys, by nesting the useListKeyboardNavigate within search results

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:26pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:26pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2025 4:26pm

@chargome chargome changed the title fix(platform): enable scrolling via keyboard buttons fix(platform): Enable scrolling via keyboard buttons Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Bundle Report

Changes will increase total bundle size by 601 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.61MB 289 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.3MB 312 bytes (0.0%) ⬆️
View changes by path for bundle: sentry-docs-server-cjs
File path Size Change
/ 62.32kB 298 bytes (0.48%)

@chargome chargome requested a review from andreiborza January 24, 2025 15:42
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the refactor :)

@andreiborza andreiborza merged commit e3f3915 into master Jan 24, 2025
13 checks passed
@andreiborza andreiborza deleted the cg/enable-keyboard-scroll branch January 24, 2025 16:28
JoshuaMoelans pushed a commit that referenced this pull request Jan 27, 2025
* enable scrolling via keyboard buttons

* conditionally add event listeners in search

* undo first try

* refactor
jan-auer added a commit that referenced this pull request Jan 28, 2025
…zation-settings

* master: (511 commits)
  docs(cloudflare): several semantic and stylistic fixes in code examples for cloudflare workers (#12482)
  chore(replay): Clarify network bandwidth and show how to reduce perf impact for mobile SDKs (#12479)
  chore(replay): Update product docs FAQ (#12474)
  ref: Drop remaining usage of `<Note>` (#12476)
  Update debugmeta.mdx (#12436)
  Fix queue_producer_transaction string termination error in example code (#12463)
  Adjust for sentry-ruby changes (#12455)
  Fixed incorrect instrument.mjs filename (#12454)
  Updating feature flags docs location (#12453)
  ref: Remove `<Note>` component in favor of using `<Alert>` (#12467)
  feat: send content feedback plausible events (#12400)
  docs(native): document how to set attribute on spans/transactions
  feat(express): Add warning about express v5 (#12465)
  chore(jira): Add instructions for installing Jira for self-hosted sentry users (#12433)
  chore: Update Codecov Bundler Plugin Version (#12459)
  Bump API schema to 421589ca (#12461)
  fix(platform): Enable scrolling via keyboard buttons (#12460)
  feat: Update `Expandable` style (#12457)
  Add Kotlin examples and fix typo in Java and Android Scopes docs (#12458)
  doc(js): Document how to set attribute on all spans (#12449)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants