Skip to content

fix(java): mention that send-default-pii must be enabled for HTTP request bodies to be captured #12799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Feb 21, 2025

DESCRIBE YOUR PR

Closes #12105

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 1:38pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 1:38pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 1:38pm

@lcian lcian requested a review from adinauer February 21, 2025 11:20
Copy link

codecov bot commented Feb 21, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/O9i2_t1s559KIgfc90R1g/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/O9i2_t1s559KIgfc90R1g/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/kdSpaPexceeLxvb677q9o/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/kdSpaPexceeLxvb677q9o/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, see comment

@lcian lcian enabled auto-merge (squash) February 24, 2025 13:27
@lcian lcian merged commit 8b86428 into master Feb 24, 2025
11 checks passed
@lcian lcian deleted the lcian/fix/java-request-body-size-send-default-pii branch February 24, 2025 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Indicate a note about sendDefaultPII in the documentation
3 participants